From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, johan@kernel.org,
linux-usb@vger.kernel.org, alberto.vignani@fastwebnet.it
Subject: Re: [PATCH v1 1/2] PCI: Disable MSI for Pericom PCIe-USB adapter
Date: Fri, 6 Nov 2020 11:56:07 +0200 [thread overview]
Message-ID: <20201106095607.GE4077@smile.fi.intel.com> (raw)
In-Reply-To: <add5a26bd1feb562867a46206ad7cd796b88b65c.camel@infradead.org>
On Thu, Nov 05, 2020 at 08:46:03PM +0000, David Woodhouse wrote:
> On Thu, 2020-11-05 at 20:06 +0200, Andy Shevchenko wrote:
> > Pericom PCIe-USB adapter ambiguously advertises MSI, but documentation says
> > "The MSI Function is not implemented on this device." in the chapters 7.3.27,
> > 7.3.29-7.3.31.
>
> I don't think it can be ambiguous, surely? Either it does advertise it,
> or it doesn't. It doesn't just give you subtle hints that it *might*
> support MSI, but it isn't sure...
I will drop the word from commit message, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-06 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 18:06 [PATCH v1 1/2] PCI: Disable MSI for Pericom PCIe-USB adapter Andy Shevchenko
2020-11-05 18:06 ` [PATCH v1 2/2] PCI: Use predefined Pericom vendor ID Andy Shevchenko
2020-11-05 20:42 ` [PATCH v1 1/2] PCI: Disable MSI for Pericom PCIe-USB adapter Ben Dooks
2020-11-06 9:57 ` Andy Shevchenko
2020-11-05 20:46 ` David Woodhouse
2020-11-06 9:56 ` Andy Shevchenko [this message]
2020-11-06 10:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106095607.GE4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alberto.vignani@fastwebnet.it \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=johan@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).