From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96D4BC56201 for ; Wed, 18 Nov 2020 18:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 457F8246B7 for ; Wed, 18 Nov 2020 18:39:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KHZ7aizc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726618AbgKRSje (ORCPT ); Wed, 18 Nov 2020 13:39:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbgKRSjd (ORCPT ); Wed, 18 Nov 2020 13:39:33 -0500 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6242C0613D6 for ; Wed, 18 Nov 2020 10:39:31 -0800 (PST) Received: by mail-pj1-x1041.google.com with SMTP id kk16so852412pjb.1 for ; Wed, 18 Nov 2020 10:39:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IS8KqvtGpvchc3pdVmAI45zcVonfW9i7VEyA+0SXwEk=; b=KHZ7aizcPD3KFmUYyRLDRAPwX+xZUdeK+inF8t7KSoc8CIO2d4OrwpEDRaX7ZCdzX1 5ntmaT4E4o50mHiPmm5ata9Fisx1PUskkp25ZUSja6PM2ymMfGTRg8TzsjK9yYeZtLWU 9FOGPj9Cu5T0uWyKt8rbLtnlAKuJJx5IdNhZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IS8KqvtGpvchc3pdVmAI45zcVonfW9i7VEyA+0SXwEk=; b=S5Qq6ZJdExAl+l6mIUEkNh9GEcaz08K4WgJkyC+20q65iY3rnmpX24i2OaeNdtR+/g nHtRVMFZlFXFPamVKOEU69KUxnCjI5hTgtV8zxJDBNKfe0Tzm8lgaUXNCuZPFUI27AQW VUP02EL3/psOAbaD9EXq3+UCMNvVqURcFDG4SS3bASrhsOMO/PIll+HjrMEcho7glUjQ L9rNlU6/MlTISSNzKy1/d798NjZ5EZstaWBGDMWzUJ5AGNyAZsTES+qinZlQ7jLQQ4lU RGYXb4200SbmQE20yNulkbEfmmN6PGV6AZr+TeLCXBDiCBdN9GpMvB3JFUvOm74WXKXr ghxA== X-Gm-Message-State: AOAM530DRkiQexMwYQFTQ574OzIAghtqMequpavYlcCuTQ0BJDju9XR0 8nelsOvCGve9qlK1EoaCW98FqA== X-Google-Smtp-Source: ABdhPJweHbHek1SIEw8iwFk9D76M1BOkOrOl/RQAY4++lcIH3vB9PS5TWTzt0p0LaAQdaxqaD7xCUA== X-Received: by 2002:a17:90b:93:: with SMTP id bb19mr394736pjb.102.1605724771392; Wed, 18 Nov 2020 10:39:31 -0800 (PST) Received: from google.com ([2620:15c:202:201:a28c:fdff:fef0:49dd]) by smtp.gmail.com with ESMTPSA id 12sm3376992pjt.25.2020.11.18.10.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 10:39:30 -0800 (PST) Date: Wed, 18 Nov 2020 10:39:29 -0800 From: Prashant Malani To: Heikki Krogerus Cc: Benson Leung , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [RFC PATCH 0/3] usb: typec: Product Type time Message-ID: <20201118183929.GA3652649@google.com> References: <20201118150059.3419-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118150059.3419-1-heikki.krogerus@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Heikki, Thanks for developing these patches :) On Wed, Nov 18, 2020 at 06:00:56PM +0300, Heikki Krogerus wrote: > Hi Prashant, > > The original discussion [1]. > > This proposal is in practice a compromise. I came to the conclusion > that we probable should expose the product type separately after all. > The reason for that is because we may in some cases actually know the > product type even when we don't have access to the Discover Identity > response. UCSI for example in practice gives us at least the cable > product type even though it does not let us know the response to the > Discover Identity command. > > So my proposal here is that we add an attribute for the product type > itself, showing the product type as a string. Then we also add the > attribute for the product type specific VDOs which we place under the > identity directory more or less the way you originally proposed. Sounds good to me. Best regards, -Prashant