From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Li Jun <jun.li@nxp.com>
Cc: heikki.krogerus@linux.intel.com, robh+dt@kernel.org,
rafael@kernel.org, gregkh@linuxfoundation.org,
hdegoede@redhat.com, lee.jones@linaro.org,
mika.westerberg@linux.intel.com, dmitry.torokhov@gmail.com,
prabhakar.mahadev-lad.rj@bp.renesas.com,
laurent.pinchart+renesas@ideasonboard.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-imx@nxp.com, peter.chen@nxp.com
Subject: Re: [PATCH v6 5/6] usb: typec: mux: add typec switch via general mux control
Date: Mon, 23 Nov 2020 17:31:04 +0200 [thread overview]
Message-ID: <20201123153104.GI4077@smile.fi.intel.com> (raw)
In-Reply-To: <1606140096-1382-5-git-send-email-jun.li@nxp.com>
On Mon, Nov 23, 2020 at 10:01:35PM +0800, Li Jun wrote:
> The general mux controller can be easily extended to support
> various mux selection, this especially fits typec orientation
> switch block with a dedicated driver.
...
> @@ -42,10 +43,8 @@ static void *typec_switch_match(struct device_connection *con, int ep,
> if (con->id && !fwnode_is_compatible(con->fwnode, con->id) &&
> !fwnode_property_present(con->fwnode, con->id))
> return NULL;
> -
> dev = class_find_device(&typec_mux_class, NULL, con->fwnode,
> switch_fwnode_match);
> -
> return dev ? to_typec_switch(dev) : ERR_PTR(-EPROBE_DEFER);
> }
>
Not related change.
...
> + if (sw->mux_ctrl)
> + return typec_switch_mux_ctrl(sw->mux_ctrl, orientation);
> + else
Redundant.
> + return sw->set(sw, orientation);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-23 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 14:01 [PATCH v6 1/6] dt-bindings: usb: add documentation for typec switch simple driver Li Jun
2020-11-23 14:01 ` [PATCH v6 2/6] device property: Add fwnode_is_compatible() and device_is_compatible() helpers Li Jun
2020-11-23 14:01 ` [PATCH v6 3/6] usb: typec: mux: add "compatible" property for switch match Li Jun
2020-11-23 14:01 ` [PATCH v6 4/6] usb: typec: mux: use fwnode's dev for driver module user count Li Jun
2020-11-26 11:58 ` Heikki Krogerus
2020-11-23 14:01 ` [PATCH v6 5/6] usb: typec: mux: add typec switch via general mux control Li Jun
2020-11-23 15:31 ` Andy Shevchenko [this message]
2020-11-24 2:15 ` Jun Li
2020-11-23 14:01 ` [PATCH v6 6/6] usb: typec: mux: add typec switch simple driver Li Jun
2020-11-26 11:59 ` Heikki Krogerus
2020-11-30 21:47 ` [PATCH v6 1/6] dt-bindings: usb: add documentation for " Rob Herring
2020-12-01 3:13 ` Jun Li
2020-12-03 12:24 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123153104.GI4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).