From: Peter Chen <peter.chen@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/3] usb: phy: phy-mxs-usb: Use of_device_get_match_data()
Date: Wed, 25 Nov 2020 01:58:11 +0000 [thread overview]
Message-ID: <20201125015742.GF9929@b29397-desktop> (raw)
In-Reply-To: <CAOMZO5A91b1cVgakrpPtGpGiMDzCKQ1Z37Ae8UX4LbskwYO4gw@mail.gmail.com>
On 20-11-24 22:21:40, Fabio Estevam wrote:
> Hi Peter,
>
> On Tue, Nov 24, 2020 at 10:15 PM Peter Chen <peter.chen@nxp.com> wrote:
>
> > > - mxs_phy->data = of_id->data;
> > > + mxs_phy->data = of_device_get_match_data(&pdev->dev);
> >
> > You may forget the error handling for it, eg, -ENODEV.
>
> How can this happen?
When adding the new SoCs, the new compatible is added at dts, but forget
adding at device driver's of_device_id table?
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2020-11-25 1:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 16:39 [PATCH 1/3] usb: phy: phy-mxs-usb: Use of_device_get_match_data() Fabio Estevam
2020-11-24 16:39 ` [PATCH 2/3] usb: chipidea: usbmisc_imx: " Fabio Estevam
2020-11-24 16:39 ` [PATCH 3/3] usb: chipidea: ci_hdrc_imx: " Fabio Estevam
2020-11-25 1:15 ` [PATCH 1/3] usb: phy: phy-mxs-usb: " Peter Chen
2020-11-25 1:21 ` Fabio Estevam
2020-11-25 1:58 ` Peter Chen [this message]
2020-11-25 2:13 ` Fabio Estevam
2020-11-25 4:48 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125015742.GF9929@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).