* [PATCH] usb: chipidea: ci_hdrc_imx: Pass DISABLE_STREAMING flag to imx6ul
@ 2020-11-27 16:44 Fabio Estevam
2020-11-30 6:33 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2020-11-27 16:44 UTC (permalink / raw)
To: Peter.Chen; +Cc: gregkh, linux-usb, Fabio Estevam, stable
According to the i.MX6UL Errata document:
https://www.nxp.com/docs/en/errata/IMX6ULCE.pdf
ERR007881 also affects i.MX6UL, so pass the CI_HDRC_DISABLE_STREAMING
flag to workaround the issue.
Cc: <stable@vger.kernel.org>
Fixes: 52fe568e5d71 ("usb: chipidea: imx: add imx6ul usb support")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index 25c65accf089..e111009cc49e 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -57,7 +57,8 @@ static const struct ci_hdrc_imx_platform_flag imx6sx_usb_data = {
static const struct ci_hdrc_imx_platform_flag imx6ul_usb_data = {
.flags = CI_HDRC_SUPPORTS_RUNTIME_PM |
- CI_HDRC_TURN_VBUS_EARLY_ON,
+ CI_HDRC_TURN_VBUS_EARLY_ON |
+ CI_HDRC_DISABLE_STREAMING,
};
static const struct ci_hdrc_imx_platform_flag imx7d_usb_data = {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: chipidea: ci_hdrc_imx: Pass DISABLE_STREAMING flag to imx6ul
2020-11-27 16:44 [PATCH] usb: chipidea: ci_hdrc_imx: Pass DISABLE_STREAMING flag to imx6ul Fabio Estevam
@ 2020-11-30 6:33 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2020-11-30 6:33 UTC (permalink / raw)
To: Fabio Estevam
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
stable@vger.kernel.org
On 20-11-27 13:44:52, Fabio Estevam wrote:
> According to the i.MX6UL Errata document:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6ULCE.pdf&data=04%7C01%7CPeter.Chen%40nxp.com%7C335258a1babc49be430c08d892f3d299%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637420923191179142%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=Fep8eahQfHYpVv7l4fv%2BnwQxyoKl5E0qKmr61Joqm1A%3D&reserved=0
>
> ERR007881 also affects i.MX6UL, so pass the CI_HDRC_DISABLE_STREAMING
> flag to workaround the issue.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 52fe568e5d71 ("usb: chipidea: imx: add imx6ul usb support")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 25c65accf089..e111009cc49e 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -57,7 +57,8 @@ static const struct ci_hdrc_imx_platform_flag imx6sx_usb_data = {
>
> static const struct ci_hdrc_imx_platform_flag imx6ul_usb_data = {
> .flags = CI_HDRC_SUPPORTS_RUNTIME_PM |
> - CI_HDRC_TURN_VBUS_EARLY_ON,
> + CI_HDRC_TURN_VBUS_EARLY_ON |
> + CI_HDRC_DISABLE_STREAMING,
> };
>
> static const struct ci_hdrc_imx_platform_flag imx7d_usb_data = {
> --
Hi Fabio,
Does the customer really meet this issue? If it does, please use
CI_HDRC_DISABLE_DEVICE_STREAMING instead of CI_HDRC_DISABLE_STREAMING,
since the latter will disable stream mode for host as well.
--
Thanks,
Peter Chen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 6:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 16:44 [PATCH] usb: chipidea: ci_hdrc_imx: Pass DISABLE_STREAMING flag to imx6ul Fabio Estevam
2020-11-30 6:33 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).