From: Peter Chen <peter.chen@nxp.com>
To: Zou Wei <zou_wei@huawei.com>
Cc: "pawell@cadence.com" <pawell@cadence.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] usb: cdnsp: Mark cdnsp_gadget_ops with static keyword
Date: Wed, 9 Dec 2020 02:40:28 +0000 [thread overview]
Message-ID: <20201209023958.GB995@b29397-desktop> (raw)
In-Reply-To: <1607430649-116383-1-git-send-email-zou_wei@huawei.com>
On 20-12-08 20:30:49, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/usb/cdns3/cdnsp-gadget.c:1546:29: warning: symbol 'cdnsp_gadget_ops' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/usb/cdns3/cdnsp-gadget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-gadget.c
> index 9716273..c7c5d0a 100644
> --- a/drivers/usb/cdns3/cdnsp-gadget.c
> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
> @@ -1543,7 +1543,7 @@ static int cdnsp_gadget_pullup(struct usb_gadget *gadget, int is_on)
> return 0;
> }
>
> -const struct usb_gadget_ops cdnsp_gadget_ops = {
> +static const struct usb_gadget_ops cdnsp_gadget_ops = {
> .get_frame = cdnsp_gadget_get_frame,
> .wakeup = cdnsp_gadget_wakeup,
> .set_selfpowered = cdnsp_gadget_set_selfpowered,
> --
Applied, thanks.
--
Thanks,
Peter Chen
prev parent reply other threads:[~2020-12-09 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 12:30 [PATCH -next] usb: cdnsp: Mark cdnsp_gadget_ops with static keyword Zou Wei
2020-12-09 2:40 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209023958.GB995@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).