From: Utkarsh Patel <utkarsh.h.patel@intel.com>
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: heikki.krogerus@linux.intel.com, pmalani@chromium.org,
enric.balletbo@collabora.com, rajmohan.mani@intel.com,
azhar.shaikh@intel.com, Utkarsh Patel <utkarsh.h.patel@intel.com>
Subject: [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4
Date: Tue, 8 Dec 2020 20:24:08 -0800 [thread overview]
Message-ID: <20201209042408.23079-2-utkarsh.h.patel@intel.com> (raw)
In-Reply-To: <20201209042408.23079-1-utkarsh.h.patel@intel.com>
USB4 specification chapter 3 indicates that cable data rates have to be
rounded for USB4 device to operate as USB4.
With that configure cable generation value to use rounded data rates for
USB4.
Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
---
Changes in v4:
- Removed usage of tbt_mode_vdo since data rates should always be rounded
in the case of USB4.
- Updated commit message to reflect the change.
Changes in v3:
- Moved TBT_CABLE_ROUNDED_SUPPORT assignment to the same line.
Changes in v2:
- No change.
---
drivers/usb/typec/mux/intel_pmc_mux.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
index e58ae8a7fefb..cf37a59ce130 100644
--- a/drivers/usb/typec/mux/intel_pmc_mux.c
+++ b/drivers/usb/typec/mux/intel_pmc_mux.c
@@ -327,6 +327,11 @@ pmc_usb_mux_usb4(struct pmc_usb_port *port, struct typec_mux_state *state)
fallthrough;
default:
req.mode_data |= PMC_USB_ALTMODE_ACTIVE_CABLE;
+
+ /* Configure data rate to rounded in the case of Active TBT3
+ * and USB4 cables.
+ */
+ req.mode_data |= PMC_USB_ALTMODE_TBT_GEN(1);
break;
}
--
2.17.1
next prev parent reply other threads:[~2020-12-09 4:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 4:24 [PATCH v4 0/1] Thunderbolt3/USB4 cable rounded and active cable plug link training support Utkarsh Patel
2020-12-09 4:24 ` Utkarsh Patel [this message]
2020-12-10 11:50 ` [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4 Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209042408.23079-2-utkarsh.h.patel@intel.com \
--to=utkarsh.h.patel@intel.com \
--cc=azhar.shaikh@intel.com \
--cc=enric.balletbo@collabora.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=rajmohan.mani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).