[PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC

linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC
       [not found] <20201209165733.8204-1-a-govindraju@ti.com>
@ 2020-12-09 16:57 ` Aswath Govindraju
  2020-12-09 19:33   ` Rob Herring
  2020-12-09 19:34   ` Rob Herring
  0 siblings, 2 replies; 4+ messages in thread
From: Aswath Govindraju @ 2020-12-09 16:57 UTC (permalink / raw)
  Cc: Sekhar Nori, Aswath Govindraju, Greg Kroah-Hartman, Rob Herring,
	Roger Quadros, linux-usb, devicetree, linux-kernel

Add compatible string in j721e-usb binding file as similar USB subsystem
is present in AM64.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
 Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
index 388245b91a55..05d976bb06d0 100644
--- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
@@ -11,8 +11,11 @@ maintainers:
 
 properties:
   compatible:
-    items:
-      - const: ti,j721e-usb
+    anyOf:
+      - items:
+	  - const: ti,j721e-usb
+      - items:
+	  - const: ti,am64-usb
 
   reg:
     description: module registers
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC
  2020-12-09 16:57 ` [PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC Aswath Govindraju
@ 2020-12-09 19:33   ` Rob Herring
  2020-12-09 19:34   ` Rob Herring
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-12-09 19:33 UTC (permalink / raw)
  To: Aswath Govindraju
  Cc: linux-kernel, devicetree, linux-usb, Rob Herring, Roger Quadros,
	Greg Kroah-Hartman, Sekhar Nori

On Wed, 09 Dec 2020 22:27:32 +0530, Aswath Govindraju wrote:
> Add compatible string in j721e-usb binding file as similar USB subsystem
> is present in AM64.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> Acked-by: Roger Quadros <rogerq@ti.com>
> ---
>  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml:16:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
Traceback (most recent call last):
  File "/usr/local/bin/dt-extract-example", line 45, in <module>
    binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
  File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load
    return constructor.get_single_data()
  File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data
    node = self.composer.get_single_node()
  File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
  File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 850, in _ruamel_yaml.CParser._compose_sequence_node
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 731, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning for the next token
found character that cannot start any token
  in "<unicode string>", line 16, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/usb/ti,j721e-usb.example.dts] Error 1
make[1]: *** Deleting file 'Documentation/devicetree/bindings/usb/ti,j721e-usb.example.dts'
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123
make: *** [Makefile:1364: dt_binding_check] Error 2


See https://patchwork.ozlabs.org/patch/1413512

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC
  2020-12-09 16:57 ` [PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC Aswath Govindraju
  2020-12-09 19:33   ` Rob Herring
@ 2020-12-09 19:34   ` Rob Herring
  2020-12-10  5:27     ` [EXTERNAL] " Aswath Govindraju
  1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2020-12-09 19:34 UTC (permalink / raw)
  To: Aswath Govindraju
  Cc: Sekhar Nori, Greg Kroah-Hartman, Roger Quadros, linux-usb,
	devicetree, linux-kernel

On Wed, Dec 09, 2020 at 10:27:32PM +0530, Aswath Govindraju wrote:
> Add compatible string in j721e-usb binding file as similar USB subsystem
> is present in AM64.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> Acked-by: Roger Quadros <rogerq@ti.com>
> ---
>  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> index 388245b91a55..05d976bb06d0 100644
> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> @@ -11,8 +11,11 @@ maintainers:
>  
>  properties:
>    compatible:
> -    items:
> -      - const: ti,j721e-usb
> +    anyOf:
> +      - items:
> +	  - const: ti,j721e-usb
> +      - items:
> +	  - const: ti,am64-usb

Use 'enum'.

>  
>    reg:
>      description: module registers
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [EXTERNAL] Re: [PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC
  2020-12-09 19:34   ` Rob Herring
@ 2020-12-10  5:27     ` Aswath Govindraju
  0 siblings, 0 replies; 4+ messages in thread
From: Aswath Govindraju @ 2020-12-10  5:27 UTC (permalink / raw)
  To: Rob Herring
  Cc: Sekhar Nori, Greg Kroah-Hartman, Roger Quadros, linux-usb,
	devicetree, linux-kernel

Hi Robert,

On 10/12/20 1:04 am, Rob Herring wrote:
> On Wed, Dec 09, 2020 at 10:27:32PM +0530, Aswath Govindraju wrote:
>> Add compatible string in j721e-usb binding file as similar USB subsystem
>> is present in AM64.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> Acked-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> index 388245b91a55..05d976bb06d0 100644
>> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> @@ -11,8 +11,11 @@ maintainers:
>>  
>>  properties:
>>    compatible:
>> -    items:
>> -      - const: ti,j721e-usb
>> +    anyOf:
>> +      - items:
>> +	  - const: ti,j721e-usb
>> +      - items:
>> +	  - const: ti,am64-usb
> 
> Use 'enum'.
> 
Thank you for the comments.

I used anyOf to mention that the compatible strings can be either used
separately or together in the DT files after referring [1].

Using enum brought in constraints such as if one compatible string is
used the other cannot be used.

The error that I made was use of '\t' at the start of the lines. I will
correct it and send a respin.


[1]https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/example-schema.yaml

Thanks,
Aswath

>>  
>>    reg:
>>      description: module registers
>> -- 
>> 2.17.1
>>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-10  5:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20201209165733.8204-1-a-govindraju@ti.com>
2020-12-09 16:57 ` [PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC Aswath Govindraju
2020-12-09 19:33   ` Rob Herring
2020-12-09 19:34   ` Rob Herring
2020-12-10  5:27     ` [EXTERNAL] " Aswath Govindraju

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).