From: Jung Daehwan <dh10.jung@samsung.com>
To: Felipe Balbi <balbi@kernel.org>, Wesley Cheng <wcheng@codeaurora.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"supporter:USB SUBSYSTEM open list:DESIGNWARE USB3 DRD IP
DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Subject: Re: usb: dwc3: gadget: skip pullup and set_speed after suspend
Date: Mon, 1 Feb 2021 15:06:46 +0900 [thread overview]
Message-ID: <20210201060646.GA188943@ubuntu> (raw)
In-Reply-To: <20210201054539.GA188887@ubuntu>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Sun, Jan 24, 2021 at 05:31:57PM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Daehwan Jung <dh10.jung@samsung.com> writes:
> > Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after
> > entering suspend. That's why it needs to check whether suspend
> >
> > 1. dwc3 sends disconnect uevent and turn off. (suspend)
> > 2. Platform side causes pullup or set_speed(e.g., adbd closes ffs node)
> > 3. It causes unexpected behavior like ITMON error.
>
> please collect dwc3 trace events showing this problem.
>
> --
> balbi
Hi, balbi
I'm sorry for late reply. I pulled in belo patch and that issue didn't occur
usb: dwc3: gadget: Restart DWC3 gadget when enabling pullup
@ Wesley cheng
But, I think it needs to modify pm_rumtime_put to pm_runtime_put_sync_suspend
for syncronization. pm_rumtime_put calls rumtime_idle not runtime_suspend
Please check it.
usb: dwc3: gadget: Allow runtime suspend if UDC unbinded
Best Regards,
Jung Daehwan
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2021-02-01 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210120035123epcas2p2048f6d9896bd21f19d939a56fe0b6610@epcas2p2.samsung.com>
2021-01-20 3:39 ` usb: dwc3: gadget: skip pullup and set_speed after suspend Daehwan Jung
2021-01-21 1:00 ` Thinh Nguyen
2021-01-21 6:49 ` Jung Daehwan
2021-01-21 7:44 ` Wesley Cheng
2021-01-21 8:13 ` Jung Daehwan
2021-01-22 3:32 ` Wesley Cheng
2021-01-21 7:11 ` Jung Daehwan
2021-01-24 15:31 ` Felipe Balbi
[not found] ` <20210201054539.GA188887@ubuntu>
2021-02-01 6:06 ` Jung Daehwan [this message]
[not found] <CGME20210122065248epcas2p19a972d3a385b91d6e05a16f2ef7b0dd6@epcas2p1.samsung.com>
[not found] ` <20210122064125.GA121941@ubuntu>
2021-01-22 7:15 ` Jung Daehwan
2021-01-27 3:34 ` Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201060646.GA188943@ubuntu \
--to=dh10.jung@samsung.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).