From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F9FC433E6 for ; Wed, 17 Mar 2021 15:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 028C064F21 for ; Wed, 17 Mar 2021 15:48:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231951AbhCQPsK (ORCPT ); Wed, 17 Mar 2021 11:48:10 -0400 Received: from netrider.rowland.org ([192.131.102.5]:59683 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S232347AbhCQPsF (ORCPT ); Wed, 17 Mar 2021 11:48:05 -0400 Received: (qmail 489791 invoked by uid 1000); 17 Mar 2021 11:11:59 -0400 Date: Wed, 17 Mar 2021 11:11:59 -0400 From: Alan Stern To: taehyun cho Cc: balbi@kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: remove 'pm_runtime_set_active' in resume callback Message-ID: <20210317151159.GA488655@rowland.harvard.edu> References: <20210315074317.7736-1-taehyun.cho@samsung.com> <20210315141335.GA402778@rowland.harvard.edu> <20210317082520.GB138912@rack03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317082520.GB138912@rack03> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Mar 17, 2021 at 05:25:20PM +0900, taehyun cho wrote: > On Mon, Mar 15, 2021 at 10:13:35AM -0400, Alan Stern wrote: > > On Mon, Mar 15, 2021 at 04:43:17PM +0900, taehyun cho wrote: > > > 'pm_runtime_set_active' sets a flag to describe rumtime status. > > > This flag is automatically set in pm_runtime_get_sync/put_sync API. > > > 'pm_runtime_set_active' checks the runtime status of parent device. > > > As a result, the below error message is printed. > > > dwc3 11110000.dwc3: runtime PM trying to activate child device > > > 11110000.dwc3 but parent (11110000.usb) is not active. > > > > This is very suspicious. That error message indicates a real error is > > present; removing these pm_runtime_set_active calls won't fix the error. > > > > You need to determine why the parent platform device 11110000.usb isn't > > active when the dwc3 probe and resume routines are called. It seems > > likely that there is a bug in the platform device's driver. > > > > Alan Stern > > > > Alan, > > Thanks to your comments, I checked our platform device driver and found > the problem. Our parent platform device didn't set active in resume > callback. This made a problem. Ah, good. Does the platform driver set the active flag in its probe routine? > Thank you for the help and sorry for > disturbing you. No problem at all. Alan Stern