Re: [PATCH v8 06/13] phy: tegra: xusb: Add sleepwalk and suspend/resume

Thierry Reding
2021-03-31T16:39:19Z

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

On Tue, Mar 30, 2021 at 07:53:32PM +0530, Vinod Koul wrote:
> On 25-03-21, 17:40, Thierry Reding wrote:
> > From: JC Kuo <jckuo@nvidia.com>
> >
> > This commit adds sleepwalk/wake and suspend/resume interfaces
> > to Tegra XUSB PHY driver.
> >
> > Tegra XUSB host controller driver makes use of sleepwalk functions
> > to enable/disable sleepwalk circuit which is in always-on partition
> > and can respond to USB resume signals when controller is not powered.
> > Sleepwalk can be enabled/disabled for any USB UPHY individually.
> >
> > - tegra_xusb_padctl_enable_phy_sleepwalk()
> > - tegra_xusb_padctl_disable_phy_sleepwalk()
> >
> > Tegra XUSB host controller driver makes use of wake functions to
> > enable/disable/query wake circuit which is in always-on partition
> > can wake system up when USB resume happens.
> > Wake circuit can be enabled/disabled for any USB PHY individually.
> >
> > - tegra_xusb_padctl_enable_phy_wake()
> > - tegra_xusb_padctl_disable_phy_wake()
> > - tegra_xusb_padctl_remote_wake_detected()
> >
> > This commit also adds two system suspend stubs that can be used to
> > save and restore XUSB PADCTL context during system suspend and
> > resume.
> > - tegra_xusb_padctl_suspend_noirq()
> > - tegra_xusb_padctl_resume_noirq()
>
> Acked-By: Vinod Koul <vkoul@kernel.org>

Thanks. I didn't see an Acked-by on patches 7-9. Did I miss them or did
you not get around to that yet?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]