Re: [PATCH v8 06/13] phy: tegra: xusb: Add sleepwalk and suspend/resume

Thierry Reding
2021-03-31T16:52:47Z

[-- Attachment #1: Type: text/plain, Size: 2511 bytes --]

On Wed, Mar 31, 2021 at 06:45:25PM +0200, Thierry Reding wrote:
> On Wed, Mar 31, 2021 at 06:38:39PM +0200, Thierry Reding wrote:
> > On Tue, Mar 30, 2021 at 07:53:32PM +0530, Vinod Koul wrote:
> > > On 25-03-21, 17:40, Thierry Reding wrote:
> > > > From: JC Kuo <jckuo@nvidia.com>
> > > >
> > > > This commit adds sleepwalk/wake and suspend/resume interfaces
> > > > to Tegra XUSB PHY driver.
> > > >
> > > > Tegra XUSB host controller driver makes use of sleepwalk functions
> > > > to enable/disable sleepwalk circuit which is in always-on partition
> > > > and can respond to USB resume signals when controller is not powered.
> > > > Sleepwalk can be enabled/disabled for any USB UPHY individually.
> > > >
> > > > - tegra_xusb_padctl_enable_phy_sleepwalk()
> > > > - tegra_xusb_padctl_disable_phy_sleepwalk()
> > > >
> > > > Tegra XUSB host controller driver makes use of wake functions to
> > > > enable/disable/query wake circuit which is in always-on partition
> > > > can wake system up when USB resume happens.
> > > > Wake circuit can be enabled/disabled for any USB PHY individually.
> > > >
> > > > - tegra_xusb_padctl_enable_phy_wake()
> > > > - tegra_xusb_padctl_disable_phy_wake()
> > > > - tegra_xusb_padctl_remote_wake_detected()
> > > >
> > > > This commit also adds two system suspend stubs that can be used to
> > > > save and restore XUSB PADCTL context during system suspend and
> > > > resume.
> > > > - tegra_xusb_padctl_suspend_noirq()
> > > > - tegra_xusb_padctl_resume_noirq()
> > >
> > > Acked-By: Vinod Koul <vkoul@kernel.org>
> >
> > Thanks. I didn't see an Acked-by on patches 7-9. Did I miss them or did
> > you not get around to that yet?
>
> Patch 10 is also missing an Acked-by, I think.

Hang on, I've mixed these up. Patches 7 and 8 were for soc/tegra and
dt-bindings, respectively. Patches 9-11 were for the PHY subsystem, so
you may have missed them because they were not contiguous within the
series. The reason is that patch 9 depends on patch 7, though in
retrospect it might have been clearer to put 7 and 8 before the whole
set of the PHY patches.

Apologies for that. Could you take a look at 9 through 11? 9 and 11 are
pretty big, but it's really just the Tegra210 and Tegra186 specific
implementations of the functionality introduced in this patch.

I've also fixed up the modular build error that Nathan had pointed out
on patch 9. Let me know if you want me to resend that.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]