From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95558C433E1 for ; Sat, 27 Mar 2021 00:56:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EAC261A54 for ; Sat, 27 Mar 2021 00:56:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231201AbhC0A4C (ORCPT ); Fri, 26 Mar 2021 20:56:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:35724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231202AbhC0Azq (ORCPT ); Fri, 26 Mar 2021 20:55:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B456619F2; Sat, 27 Mar 2021 00:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616806545; bh=lo6lYnIDJUd1GsaAadMr5D9x6+TV2fWoKmvUvRWPbJY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YSakcLdgmxrQZHQqKWvJPxVUYENmn35UzQeR7TWvz/K0QsZZjYjihRYuqObd1F8ob vLj12q7PKS+blkO2ftwgIu+UKVRBY+36dtZy78vMMHmqvikCQ3j6uww+kKaH5p4j1l syHNppSel7HEKJ7YVr4yd0QAtetkcNNFFUfS/ZQRrGpxfXytnbko/GEc1nwhaBhAbo K38NNLLEAU6daudPx/KvIxVF6FaLtRPCpMX+bZ234eg8ktoqiDt/azigoRQuo5SL+w x94YEPTAKz7YoVwjJ5ieGdRCqrXzcKz5emaQkC+E3aFj6sw0P8EoVnd07bsO3C2LdO ZlQNrLHNdNiVw== Date: Sat, 27 Mar 2021 08:55:39 +0800 From: Peter Chen To: Pawel Laszczak Cc: Wang Qing , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: cdns3: delete repeated clear operations Message-ID: <20210327005539.GC28870@b29397-desktop> References: <1615603303-14518-1-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 21-03-22 07:19:46, Pawel Laszczak wrote: > Hi Peter, > > Can you add this patch to for-usb-next branch. > Feel free add your ACK base on this patch. Peter > Thanks. > > > > > > >dma_alloc_coherent already zeroes out memory, so memset is not needed. > > > >Signed-off-by: Wang Qing > > Reviewed-by: Pawel Laszczak > > >--- > > drivers/usb/cdns3/cdnsp-mem.c | 1 - > > 1 file changed, 1 deletion(-) > > > >diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c > >index 7a84e92..1d1b9a4 > >--- a/drivers/usb/cdns3/cdnsp-mem.c > >+++ b/drivers/usb/cdns3/cdnsp-mem.c > >@@ -1231,7 +1231,6 @@ int cdnsp_mem_init(struct cdnsp_device *pdev) > > if (!pdev->dcbaa) > > return -ENOMEM; > > > >- memset(pdev->dcbaa, 0, sizeof(*pdev->dcbaa)); > > pdev->dcbaa->dma = dma; > > > > cdnsp_write_64(dma, &pdev->op_regs->dcbaa_ptr); > >-- > >2.7.4 > > Regards, > Pawel Laszczak -- Thanks, Peter Chen