From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F99C433DB for ; Tue, 30 Mar 2021 10:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 915636195C for ; Tue, 30 Mar 2021 10:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbhC3Klz (ORCPT ); Tue, 30 Mar 2021 06:41:55 -0400 Received: from mga14.intel.com ([192.55.52.115]:10935 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbhC3Klc (ORCPT ); Tue, 30 Mar 2021 06:41:32 -0400 IronPort-SDR: 8wCMMwx3+84QQIAHtoj2oCuLABXKI3/NF5yc+hThFT+zq0LFVU6IodmzVHarFDGDysQaoho0Qi cdY1FAPWbDiw== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="191211290" X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="191211290" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 03:41:31 -0700 IronPort-SDR: iQmwTwy/scIftGbnpXpGawj4WiagnlNianAla164MREaORGSD4BwIQhSNMMGF9uNes3MhFfOCH ZF3WMa70tMyg== X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="418119598" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 03:41:27 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 30 Mar 2021 13:41:25 +0300 Date: Tue, 30 Mar 2021 13:41:25 +0300 From: Mika Westerberg To: Dan Carpenter Cc: Andreas Noever , Kranthi Kuntala , Michael Jamet , Yehezkel Bernat , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH 1/2] thunderbolt: Fix a leak in tb_retimer_add() Message-ID: <20210330104125.GP2542@lahna.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Mar 29, 2021 at 09:07:18AM +0300, Dan Carpenter wrote: > After the device_register() succeeds, then the correct way to clean up > is to call device_unregister(). The unregister calls both device_del() > and device_put(). Since this code was only device_del() it results in > a memory leak. > > Fixes: dacb12877d92 ("thunderbolt: Add support for on-board retimers") > Signed-off-by: Dan Carpenter > --- > This is from a new static checker warning. Not tested. With new > warnings it's also possible that I have misunderstood something > fundamental so review carefully etc. > > drivers/thunderbolt/retimer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Both patches applied to thunderbolt.git/fixes. Thanks Dan!