From: Alan Stern <stern@rowland.harvard.edu>
To: Longfang Liu <liulongfang@huawei.com>
Cc: gregkh@linuxfoundation.org, mathias.nyman@intel.com,
liudongdong3@huawei.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kong.kongxinwei@hisilicon.com,
yisen.zhuang@huawei.com
Subject: Re: [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem
Date: Thu, 8 Apr 2021 10:53:32 -0400 [thread overview]
Message-ID: <20210408145332.GA1296449@rowland.harvard.edu> (raw)
In-Reply-To: <1617889760-17733-1-git-send-email-liulongfang@huawei.com>
On Thu, Apr 08, 2021 at 09:49:18PM +0800, Longfang Liu wrote:
> (1) Add a whitelist for EHCI devices without SBRN registers.
> (2) Add Kunpeng920's EHCI device to the whitelist.
>
> Changes in v2:
> - Fix some code style issues.
> - Update function name.
>
> Longfang Liu (2):
> USB:ehci:Add a whitelist for EHCI controllers
> USB:ehci:fix Kunpeng920 ehci hardware problem
>
> drivers/usb/host/ehci-pci.c | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
I don't think we need a whole list, along with an associated lookup
routine, when there are only two entries. The total amount of code will
be smaller if you just add a check for the Kunpeng920 controller to
the existing check for the STMICRO controller.
Alan Stern
next prev parent reply other threads:[~2021-04-08 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:49 [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem Longfang Liu
2021-04-08 13:49 ` [PATCH v2 1/2] USB:ehci:Add a whitelist for EHCI controllers Longfang Liu
2021-04-08 14:53 ` Greg KH
2021-04-08 17:30 ` kernel test robot
2021-04-08 20:34 ` kernel test robot
2021-04-08 13:49 ` [PATCH v2 2/2] USB:ehci:fix Kunpeng920 ehci hardware problem Longfang Liu
2021-04-08 14:53 ` Alan Stern [this message]
2021-04-09 2:42 ` [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem liulongfang
2021-04-09 6:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408145332.GA1296449@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mathias.nyman@intel.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox