From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6713C43616 for ; Fri, 9 Apr 2021 10:06:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF4D261208 for ; Fri, 9 Apr 2021 10:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233761AbhDIKHH (ORCPT ); Fri, 9 Apr 2021 06:07:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233851AbhDIKC1 (ORCPT ); Fri, 9 Apr 2021 06:02:27 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 183D7C0613E9 for ; Fri, 9 Apr 2021 03:00:23 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id c17so3899571pfn.6 for ; Fri, 09 Apr 2021 03:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oc1E6kp+LWw/2VGNPd8azwQCeYvXeaubPfEpOpbRQdo=; b=QB4UHxUac2nlz+9P3qfDUbyePZ7dXu90DiWiercPIlT1l55e+F++e3xKpHnaJ0xo4f +cdIHswPl60VQ2ty5x6/YcV+l0Q4tlqCJoTwgTIFkhTa/sXVM1RSEcRSx3SgfoOl9ImL 5AuzfKqokkoBwo49DE7vlQv0gD5Q4N9ARbRgGmjdtbtaqAi0Ow6v1JD0x8TYm1ZaY0TW HcAx+Um3hH8kBSk26nI56N08gii4DuHPKN8bBzo5ObqXaylNCF1q94Z3+XggcRYCLLpk Be+q3gX4Rxn7q9/S3qxO2YAFN5iXr4W/nzGysNk2WpDEEqzspgTHP24gxRVZf5lr3kFT WFLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oc1E6kp+LWw/2VGNPd8azwQCeYvXeaubPfEpOpbRQdo=; b=bKFa6H4QxTS39MHdUAU+wYtdRdKgB1fp//3O8NhMKCOISy+lekXDemxQ28FpmXkQXk 9LWvUrdgmk5lLbRCk4yAwbmQbruicsYv9UAHRPXjnGTanHS7ZZuLbiHXF39HLQ0QhalU 9dIRQBMtugxf4OLAMu2ISVVLJLa/kjFE8/h0UqztAxTIYE6Ouzao+9LxUGDp2ZVA3bjC 3IYzwQbvrVyiKIC/qJseUFY67FjvE+JLmQsTA4fgEvKBT4wY8XM9/ZmuNjyaMNtOBeud tszKPUunMNnt+TIjluK0DSacJZY+Ukux1GiotTOJ9h9g3A9n65riJO65uxgH5CQkZOhq Iv3g== X-Gm-Message-State: AOAM532vh6HXkvjDy6U2gkbahLTPxfxtmKfBz8k9QlwK7ixcm9PltxeS YcimNKWXx3J6zWIF16MrkpPA X-Google-Smtp-Source: ABdhPJxi8zK3aVtLgmS32J11GEjoH50OuPViZ9D116OA2a7WyAjR29XgtTxY/Di4sLxTN6S7JOSE5A== X-Received: by 2002:a05:6a00:80b:b029:22e:e873:7f0e with SMTP id m11-20020a056a00080bb029022ee8737f0emr12097247pfk.61.1617962422520; Fri, 09 Apr 2021 03:00:22 -0700 (PDT) Received: from work ([103.77.37.131]) by smtp.gmail.com with ESMTPSA id j9sm1858435pjy.8.2021.04.09.03.00.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Apr 2021 03:00:22 -0700 (PDT) Date: Fri, 9 Apr 2021 15:30:18 +0530 From: Manivannan Sadhasivam To: Bixuan Cui Cc: linux-kernel@vger.kernel.org, agross@kernel.org, john.wanghui@huawei.com, bjorn.andersson@linaro.org, balbi@kernel.org, gregkh@linuxfoundation.org, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe() Message-ID: <20210409100018.GC31856@work> References: <20210409004945.56776-1-cuibixuan@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409004945.56776-1-cuibixuan@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Apr 09, 2021 at 08:49:45AM +0800, Bixuan Cui wrote: > There is a error message after devm_ioremap_resource failed, and the ret > is needs to be obtained through PTR_ERR(qcom->qscratch_base). > We need to move the dev_err() downwards to ensure that the ret value is > correct. > > Fixes: a4333c3a6ba9 ('usb: dwc3: Add Qualcomm DWC3 glue driver') > Reported-by: Hulk Robot > Signed-off-by: Bixuan Cui > --- > drivers/usb/dwc3/dwc3-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index e37cc58dfa55..4716ca8c753d 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -774,8 +774,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > > qcom->qscratch_base = devm_ioremap_resource(dev, parent_res); > if (IS_ERR(qcom->qscratch_base)) { > - dev_err(dev, "failed to map qscratch, err=%d\n", ret); > ret = PTR_ERR(qcom->qscratch_base); > + dev_err(dev, "failed to map qscratch, err=%d\n", ret); But this error message can be removed altogether as devm_ioremap_resource() reports it already. Thanks, Mani > goto clk_disable; > } > > -- > 2.17.1 >