From: Marcel Hamer <marcel@solidxs.se>
To: linux-usb@vger.kernel.org
Cc: Marcel Hamer <marcel@solidxs.se>
Subject: [PATCH] Add missing link states in dwc3 gadget wakeup
Date: Fri, 23 Apr 2021 15:23:14 +0200 [thread overview]
Message-ID: <20210423132314.361822-1-marcel@solidxs.se> (raw)
In dwc3_send_gadget_ep_cmd() a check is performed if the gadget needs
waking up. The following condition is checked before calling the
__dwc3_gadget_wakeup() function:
needs_wakeup = (dwc->link_state == DWC3_LINK_STATE_U1 ||
dwc->link_state == DWC3_LINK_STATE_U2 ||
dwc->link_state == DWC3_LINK_STATE_U3);
Inside __dwc3_gadget_wakeup() only link_state DWC3_LINK_STATE_U3 is checked
and link state DWC3_LINK_STATE_U1 and DWC3_LINK_STATE_U2 are considered
invalid and generate a warning becaus of the call to:
dev_WARN_ONCE(dwc->dev, ret, "wakeup failed --> %d\n", ret);
because of ret being -EINVAL.
Signed-off-by: Marcel Hamer <marcel@solidxs.se>
---
drivers/usb/dwc3/gadget.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index c7ef218e7a8c..d05a7d630410 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1972,6 +1972,8 @@ static int __dwc3_gadget_wakeup(struct dwc3 *dwc)
switch (link_state) {
case DWC3_LINK_STATE_RESET:
case DWC3_LINK_STATE_RX_DET: /* in HS, means Early Suspend */
+ case DWC3_LINK_STATE_U1:
+ case DWC3_LINK_STATE_U2:
case DWC3_LINK_STATE_U3: /* in HS, means SUSPEND */
case DWC3_LINK_STATE_RESUME:
break;
--
2.25.1
next reply other threads:[~2021-04-23 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 13:23 Marcel Hamer [this message]
2021-04-23 14:40 ` [PATCH] Add missing link states in dwc3 gadget wakeup Marcel Hamer
2021-04-23 15:04 ` Greg KH
2021-04-23 15:10 ` Marcel Hamer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423132314.361822-1-marcel@solidxs.se \
--to=marcel@solidxs.se \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox