From: Rene Rebe <rene@exactcode.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
Subject: [PATCH] unbreak all modern Seagate ATA pass-through for SMART
Date: Sat, 24 Apr 2021 22:03:16 +0200 (CEST) [thread overview]
Message-ID: <20210424.220316.855336714119430355.rene@exactcode.com> (raw)
Hi there,
for some time I already wondered why my external USB Seagate Seven
drive does not report any SMART status. Only recently did I take a
look and it turns out ATA pass-through was explicitly disabed for all
Seagate drives with 7fee72 "uas: Always apply US_FL_NO_ATA_1X quirk to
Seagate devices" in 2017. Apparently some early ones where buggy, ...
However, fast forward a couple of years and this is no longer true,
this Segate Seven even is already from 2016, and apparently first
available in 2015. I suggest removing this rather drastic global
measure, and instead only add very old broken ones with individual
quirks, should any of them still be alive ;-)
Signed-off-by: René Rebe <rene@exactcode.com>
--- linux-5.11/drivers/usb/storage/uas-detect.h.backup 2021-03-05 11:36:00.517423726 +0100
+++ linux-5.11/drivers/usb/storage/uas-detect.h 2021-03-05 11:36:16.373424544 +0100
@@ -113,8 +113,4 @@
}
- /* All Seagate disk enclosures have broken ATA pass-through support */
- if (le16_to_cpu(udev->descriptor.idVendor) == 0x0bc2)
- flags |= US_FL_NO_ATA_1X;
-
usb_stor_adjust_quirks(udev, &flags);
--
René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
https://exactcode.com | https://t2sde.org | https://rene.rebe.de
next reply other threads:[~2021-04-24 20:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 20:03 Rene Rebe [this message]
2021-04-25 2:31 ` [PATCH] unbreak all modern Seagate ATA pass-through for SMART Alan Stern
2021-04-25 7:20 ` René Rebe
2021-04-25 7:32 ` Greg KH
2021-04-25 10:41 ` Rene Rebe
2021-04-25 10:47 ` Hans de Goede
2021-04-25 10:58 ` Hans de Goede
2021-04-25 11:50 ` Rene Rebe
2021-04-25 12:00 ` Greg KH
2021-04-25 12:15 ` Rene Rebe
2021-04-25 12:27 ` Greg KH
2021-04-25 15:50 ` Rene Rebe
2021-04-25 18:14 ` Hans de Goede
2021-04-25 14:45 ` Alan Stern
2021-04-25 15:02 ` Rene Rebe
2021-04-25 18:25 ` Hans de Goede
2021-04-25 20:52 ` René Rebe
2021-04-26 8:16 ` Hans de Goede
2021-04-26 8:52 ` Hans de Goede
2021-04-26 9:40 ` Rene Rebe
2021-04-26 9:54 ` Hans de Goede
2021-04-25 10:43 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210424.220316.855336714119430355.rene@exactcode.com \
--to=rene@exactcode.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox