From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E72C433B4 for ; Sat, 24 Apr 2021 18:41:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8CCC6120D for ; Sat, 24 Apr 2021 18:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232708AbhDXSmR (ORCPT ); Sat, 24 Apr 2021 14:42:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231814AbhDXSmP (ORCPT ); Sat, 24 Apr 2021 14:42:15 -0400 Received: from mail.solidxs.nl (mail.solidxs.nl [IPv6:2a01:4f8:150:72a3::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47F1AC061574 for ; Sat, 24 Apr 2021 11:41:36 -0700 (PDT) Received: by mail.solidxs.nl (Postfix, from userid 1000) id 635834C80C46; Sat, 24 Apr 2021 20:41:33 +0200 (CEST) Date: Sat, 24 Apr 2021 20:41:33 +0200 To: Felipe Balbi Cc: Marcel Hamer , linux-usb@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Thinh Nguyen Subject: Re: [PATCH] usb: dwc3: gadget: add missing wakeup link states Message-ID: <20210424184133.GA1778359@solidxs.nl> References: <20210423152524.624619-1-marcel@solidxs.se> <87pmykksuw.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pmykksuw.fsf@kernel.org> From: Marcel Hamer Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Apr 24, 2021 at 11:08:07AM +0300, Felipe Balbi wrote: > Marcel Hamer writes: > > > In dwc3_send_gadget_ep_cmd() a check is performed if the gadget needs > > waking up. The following condition is checked before calling the > > __dwc3_gadget_wakeup() function: > > > > needs_wakeup = (dwc->link_state == DWC3_LINK_STATE_U1 || > > dwc->link_state == DWC3_LINK_STATE_U2 || > > dwc->link_state == DWC3_LINK_STATE_U3); > > > > Inside __dwc3_gadget_wakeup() only link_state DWC3_LINK_STATE_U3 is checked > > and link state DWC3_LINK_STATE_U1 and DWC3_LINK_STATE_U2 are considered > > invalid and generate a warning because of the call to: > > > > dev_WARN_ONCE(dwc->dev, ret, "wakeup failed --> %d\n", ret); > > > > because of ret being -EINVAL. > > > > Signed-off-by: Marcel Hamer > > --- > > drivers/usb/dwc3/gadget.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > index c7ef218e7a8c..d05a7d630410 100644 > > --- a/drivers/usb/dwc3/gadget.c > > +++ b/drivers/usb/dwc3/gadget.c > > @@ -1972,6 +1972,8 @@ static int __dwc3_gadget_wakeup(struct dwc3 *dwc) > > switch (link_state) { > > case DWC3_LINK_STATE_RESET: > > case DWC3_LINK_STATE_RX_DET: /* in HS, means Early Suspend */ > > + case DWC3_LINK_STATE_U1: > > + case DWC3_LINK_STATE_U2: > > I think this was fixed recently by Thinh. > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=c560e76319a94a3b9285bc426c609903408e4826 > > -- > balbi Great, I missed that. Thank you for clarifying this. Kind regards, Marcel