Re: [PATCH] usb: dwc3: gadget: Free gadget structure only after freeing endpoints

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2523 bytes --]

Hi Jack,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on peter.chen-usb/for-usb-next linus/master balbi-usb/testing/next v5.12 next-20210430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jack-Pham/usb-dwc3-gadget-Free-gadget-structure-only-after-freeing-endpoints/20210501-173239
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: alpha-allmodconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5b2764c7c290946657e27890a4265bd11bccc0dc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jack-Pham/usb-dwc3-gadget-Free-gadget-structure-only-after-freeing-endpoints/20210501-173239
        git checkout 5b2764c7c290946657e27890a4265bd11bccc0dc
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/usb/dwc3/gadget.c: In function 'dwc3_gadget_exit':
>> drivers/usb/dwc3/gadget.c:4063:2: error: implicit declaration of function 'usb_del_gadget_put'; did you mean 'usb_del_gadget_udc'? [-Werror=implicit-function-declaration]
    4063 |  usb_del_gadget_put(dwc->gadget);
         |  ^~~~~~~~~~~~~~~~~~
         |  usb_del_gadget_udc
   cc1: some warnings being treated as errors


vim +4063 drivers/usb/dwc3/gadget.c

  4058	
  4059	void dwc3_gadget_exit(struct dwc3 *dwc)
  4060	{
  4061		usb_del_gadget(dwc->gadget);
  4062		dwc3_gadget_free_endpoints(dwc);
> 4063		usb_del_gadget_put(dwc->gadget);
  4064		dma_free_coherent(dwc->sysdev, DWC3_BOUNCE_SIZE, dwc->bounce,
  4065				  dwc->bounce_addr);
  4066		kfree(dwc->setup_buf);
  4067		dma_free_coherent(dwc->sysdev, sizeof(*dwc->ep0_trb) * 2,
  4068				  dwc->ep0_trb, dwc->ep0_trb_addr);
  4069	}
  4070	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67594 bytes --]