[PATCH 0/2] *** SUBJECT HERE ***

[PATCH 0/2] *** SUBJECT HERE ***

[Saurav Girepunje]

*** BLURB HERE ***

Saurav Girepunje (2):
  usb: musb: remove unused function argument
  usb: musb: Remove unused function argument

 drivers/usb/musb/musb_host.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

--
2.25.1

[PATCH 1/2] usb: musb: remove unused function argument

[Saurav Girepunje]

Remove unused function argument from musb_tx_dma_set_mode_cppi_tusb()
in musb_host.c

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
 drivers/usb/musb/musb_host.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 8b7d22a0c0fb..978d822af2c5 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -602,12 +602,8 @@ static void musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
 	musb_writew(epio, MUSB_TXCSR, csr);
 }

-static void musb_tx_dma_set_mode_cppi_tusb(struct dma_controller *dma,
-					   struct musb_hw_ep *hw_ep,
-					   struct musb_qh *qh,
+static void musb_tx_dma_set_mode_cppi_tusb(struct musb_hw_ep *hw_ep,
 					   struct urb *urb,
-					   u32 offset,
-					   u32 *length,
 					   u8 *mode)
 {
 	struct dma_channel *channel = hw_ep->tx_channel;
@@ -633,8 +629,7 @@ static bool musb_tx_dma_program(struct dma_controller *dma,
 		musb_tx_dma_set_mode_mentor(dma, hw_ep, qh, urb, offset,
 					    &length, &mode);
 	else if (is_cppi_enabled(hw_ep->musb) || tusb_dma_omap(hw_ep->musb))
-		musb_tx_dma_set_mode_cppi_tusb(dma, hw_ep, qh, urb, offset,
-					       &length, &mode);
+		musb_tx_dma_set_mode_cppi_tusb(hw_ep, urb, &mode);
 	else
 		return false;

--
2.25.1

Re: [PATCH 1/2] usb: musb: remove unused function argument

[SAURAV GIREPUNJE]

On Fri, May 07, 2021 at 04:54:33AM +0000, SAURAV GIREPUNJE wrote:
>
>
> ________________________________
> From: Saurav Girepunje <saurav.girepunje@gmail.com>
> Sent: Friday, May 7, 2021 10:11 AM
> To: saurav.girepunje@hotmail.com <saurav.girepunje@hotmail.com>
> Cc: linux-usb@vger.kernel.org <linux-usb@vger.kernel.org>
> Subject: [PATCH 1/2] usb: musb: remove unused function argument
>
> Remove unused function argument from musb_tx_dma_set_mode_cppi_tusb()
> in musb_host.c
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>  drivers/usb/musb/musb_host.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 8b7d22a0c0fb..978d822af2c5 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -602,12 +602,8 @@ static void musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
>          musb_writew(epio, MUSB_TXCSR, csr);
>  }
>
> -static void musb_tx_dma_set_mode_cppi_tusb(struct dma_controller *dma,
> -                                          struct musb_hw_ep *hw_ep,
> -                                          struct musb_qh *qh,
> +static void musb_tx_dma_set_mode_cppi_tusb(struct musb_hw_ep *hw_ep,
>                                             struct urb *urb,
> -                                          u32 offset,
> -                                          u32 *length,
>                                             u8 *mode)
>  {
>          struct dma_channel *channel = hw_ep->tx_channel;
> @@ -633,8 +629,7 @@ static bool musb_tx_dma_program(struct dma_controller *dma,
>                  musb_tx_dma_set_mode_mentor(dma, hw_ep, qh, urb, offset,
>                                              &length, &mode);
>          else if (is_cppi_enabled(hw_ep->musb) || tusb_dma_omap(hw_ep->musb))
> -               musb_tx_dma_set_mode_cppi_tusb(dma, hw_ep, qh, urb, offset,
> -                                              &length, &mode);
> +               musb_tx_dma_set_mode_cppi_tusb(hw_ep, urb, &mode);
>          else
>                  return false;
>
> --
> 2.25.1
>

Please ignore this mail.

Re: [PATCH 0/2] *** SUBJECT HERE ***

[Greg KH]

On Fri, May 07, 2021 at 10:06:17AM +0530, Saurav Girepunje wrote:
> *** BLURB HERE ***

No subject or blurb?

> 
> Saurav Girepunje (2):
>   usb: musb: remove unused function argument
>   usb: musb: Remove unused function argument

Again, these have the same subject line, which is not allowed.

Please fix up and resend them all (we only saw 1 on the mailing list.)

thanks,

greg k-h

Re: [PATCH 0/2] *** SUBJECT HERE ***

[SAURAV GIREPUNJE]

On Fri, May 07, 2021 at 08:00:29AM +0200, Greg KH wrote:
> On Fri, May 07, 2021 at 10:06:17AM +0530, Saurav Girepunje wrote:
> > *** BLURB HERE ***
>
> No subject or blurb?
>
> >
> > Saurav Girepunje (2):
> >   usb: musb: remove unused function argument
> >   usb: musb: Remove unused function argument
>
> Again, these have the same subject line, which is not allowed.
>
> Please fix up and resend them all (we only saw 1 on the mailing list.)
>
> thanks,
>
> greg k-h


Plese ignore this mail.

I was trying to learn how to send pathes with cover letter from below
https://kernelnewbies.org/FirstKernelPatch

and did not realized that on sample command set the cc list
git format-patch -o /tmp/ --cover-letter -n --thread=shallow --cc="linux-usb@vger.kernel.org" 3b12c21^..b7ca36a