From: Johan Hovold <johan@kernel.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Eero Lehtinen <debiangamer2@gmail.com>,
Johan Hovold <johan@kernel.org>
Subject: [PATCH v2 0/3] media: fix zero-length USB control requests
Date: Mon, 31 May 2021 11:44:31 +0200 [thread overview]
Message-ID: <20210531094434.12651-1-johan@kernel.org> (raw)
The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.
Control transfers without a data stage are treated as OUT requests by
the USB stack and should be using usb_sndctrlpipe(). Failing to do so
will now trigger a warning.
This series fixes the three media drivers that got this wrong.
Johan
Changes in v2
- keep the rtl28xxu zero-length read request which is needed for
proper type detection (Eero)
Johan Hovold (3):
media: gspca/gl860: fix zero-length control requests
media: gspca/sunplus: fix zero-length control requests
media: rtl28xxu: fix zero-length control request
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 11 ++++++++++-
drivers/media/usb/gspca/gl860/gl860.c | 4 ++--
drivers/media/usb/gspca/sunplus.c | 8 ++++++--
3 files changed, 18 insertions(+), 5 deletions(-)
--
2.31.1
next reply other threads:[~2021-05-31 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 9:44 Johan Hovold [this message]
2021-05-31 9:44 ` [PATCH v2 1/3] media: gspca/gl860: fix zero-length control requests Johan Hovold
2021-05-31 9:44 ` [PATCH v2 2/3] media: gspca/sunplus: " Johan Hovold
2021-05-31 9:44 ` [PATCH v2 3/3] media: rtl28xxu: fix zero-length control request Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531094434.12651-1-johan@kernel.org \
--to=johan@kernel.org \
--cc=debiangamer2@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).