From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 1/1] usb: typec: wcove: Use LE to CPU conversion when accessing msg->header
Date: Wed, 9 Jun 2021 10:46:48 -0700 [thread overview]
Message-ID: <20210609174648.GA2172861@roeck-us.net> (raw)
In-Reply-To: <20210609172202.83377-1-andriy.shevchenko@linux.intel.com>
On Wed, Jun 09, 2021 at 08:22:02PM +0300, Andy Shevchenko wrote:
> As LKP noticed the Sparse is not happy about strict type handling:
> .../typec/tcpm/wcove.c:380:50: sparse: expected unsigned short [usertype] header
> .../typec/tcpm/wcove.c:380:50: sparse: got restricted __le16 const [usertype] header
>
> Fix this by switching to use pd_header_cnt_le() instead of pd_header_cnt()
> in the affected code.
>
> Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together")
> Fixes: 3c4fb9f16921 ("usb: typec: wcove: start using tcpm for USB PD support")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: added Rb tag (Heikki), amend Fixes tags (Greg)
> drivers/usb/typec/tcpm/wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/wcove.c b/drivers/usb/typec/tcpm/wcove.c
> index 8072e222eb99..20917d85d6f4 100644
> --- a/drivers/usb/typec/tcpm/wcove.c
> +++ b/drivers/usb/typec/tcpm/wcove.c
> @@ -378,7 +378,7 @@ static int wcove_pd_transmit(struct tcpc_dev *tcpc,
> const u8 *data = (void *)msg;
> int i;
>
> - for (i = 0; i < pd_header_cnt(msg->header) * 4 + 2; i++) {
> + for (i = 0; i < pd_header_cnt_le(msg->header) * 4 + 2; i++) {
> ret = regmap_write(wcove->regmap, USBC_TX_DATA + i,
> data[i]);
> if (ret)
> --
> 2.30.2
>
prev parent reply other threads:[~2021-06-09 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 17:22 [PATCH v2 1/1] usb: typec: wcove: Use LE to CPU conversion when accessing msg->header Andy Shevchenko
2021-06-09 17:46 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609174648.GA2172861@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox