Re: [PATCH 2/3] usb: gadget: uvc: add VIDIOC function

Laurent Pinchart
2021-06-15T02:36:03Z

Hi Greg,

On Wed, Jun 09, 2021 at 10:16:53AM +0200, Greg KH wrote:
> <resending as your email headers were b0rked causing replies to only go
> to you...>
>
> On Mon, May 31, 2021 at 12:22:38AM +0200, Michael Grzeschik wrote:
> > This patch adds support to the v4l2 VIDIOC for enum_format,
> > enum_framesizes, enum_frameintervals and try_fmt. The configfs userspace
> > setup gets parsed and this configfs data is used in the v4l2 interface
> > functions.
> >
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> > drivers/usb/gadget/function/f_uvc.c | 54 ++++
> > drivers/usb/gadget/function/uvc.h | 18 +-
> > drivers/usb/gadget/function/uvc_configfs.c | 5 +
> > drivers/usb/gadget/function/uvc_configfs.h | 2 +
> > drivers/usb/gadget/function/uvc_queue.c | 4 +-
> > drivers/usb/gadget/function/uvc_v4l2.c | 325 ++++++++++++++++++---
> > drivers/usb/gadget/function/uvc_v4l2.h | 1 +
> > drivers/usb/gadget/function/uvc_video.c | 10 +-
> > 8 files changed, 369 insertions(+), 50 deletions(-)
>
> It would be great to have some v4l developers review/ack this so we know
> if it's ok to take or not.

Done. Sorry for the delay.

tl;dr: I miss the rationale for this patch series, I don't really see
the benefit of moving code from the userspace helper application to the
kernel.

--
Regards,

Laurent Pinchart