public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: syzbot <syzbot+5f29dc6a889fc42bd896@syzkaller.appspotmail.com>,
	johan@kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, mathias.nyman@linux.intel.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING in vmk80xx_auto_attach/usb_submit_urb
Date: Sat, 12 Jun 2021 10:19:26 -0400	[thread overview]
Message-ID: <20210612141926.GA78629@rowland.harvard.edu> (raw)
In-Reply-To: <YMRbTj2RAbIFZKw6@kroah.com>

On Sat, Jun 12, 2021 at 08:59:26AM +0200, Greg KH wrote:
> On Fri, Jun 11, 2021 at 01:02:23PM -0700, syzbot wrote:
> > Hello,
> > 
> > syzbot found the following issue on:
> > 
> > HEAD commit:    614124be Linux 5.13-rc5
> > git tree:       upstream
> > console output: https://syzkaller.appspot.com/x/log.txt?x=12188667d00000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=547a5e42ca601229
> > dashboard link: https://syzkaller.appspot.com/bug?extid=5f29dc6a889fc42bd896
> > compiler:       Debian clang version 11.0.1-2
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1687ec3fd00000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=172f44ffd00000
> > 
> > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > Reported-by: syzbot+5f29dc6a889fc42bd896@syzkaller.appspotmail.com
> > 
> > usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
> > usb 1-1: config 0 descriptor??
> > ------------[ cut here ]------------
> > usb 1-1: BOGUS urb xfer, pipe 1 != type 3
> > WARNING: CPU: 1 PID: 20 at drivers/usb/core/urb.c:494 usb_submit_urb+0xacd/0x1550 drivers/usb/core/urb.c:493
> 
> Looks correct to me, you did not create a valid USB device for the
> system to use :)

The problem is that vmk80xx_write_packet submits an interrupt URB to 
the ep_tx endpoint, but vmk80xx_find_usb_endpoints will set ep_tx to the 
first OUT endpoint it finds that is either interrupt or bulk.  In this 
case it was bulk, so the driver submitted an interrupt URB to a bulk 
endpoint.

Alan Stern

      reply	other threads:[~2021-06-12 14:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 20:02 [syzbot] WARNING in vmk80xx_auto_attach/usb_submit_urb syzbot
2021-06-12  6:59 ` Greg KH
2021-06-12 14:19   ` Alan Stern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210612141926.GA78629@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=syzbot+5f29dc6a889fc42bd896@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox