From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B051C48BC2 for ; Sun, 27 Jun 2021 14:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC14B619C6 for ; Sun, 27 Jun 2021 14:29:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231288AbhF0OcR (ORCPT ); Sun, 27 Jun 2021 10:32:17 -0400 Received: from netrider.rowland.org ([192.131.102.5]:37867 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S231210AbhF0OcQ (ORCPT ); Sun, 27 Jun 2021 10:32:16 -0400 Received: (qmail 625995 invoked by uid 1000); 27 Jun 2021 10:29:52 -0400 Date: Sun, 27 Jun 2021 10:29:52 -0400 From: Alan Stern To: Igor Kononenko Cc: Felipe Balbi , Greg Kroah-Hartman , Jens Axboe , openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] fms: Add TOC/PMA/ATIP DVD-ROM capabilities Message-ID: <20210627142952.GE624763@rowland.harvard.edu> References: <20210626211820.107310-1-i.kononenko@yadro.com> <20210626211820.107310-4-i.kononenko@yadro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210626211820.107310-4-i.kononenko@yadro.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sun, Jun 27, 2021 at 12:18:16AM +0300, Igor Kononenko wrote: > The DVD-ROM required the SCSI 6.25 READ TOC/PMA/ATIP Command formats: > * Response Format 0000b: Formatted TOC > * Response Format 0001b: Multi-session Information > (MMC-6 Specification). > > This patch adds an implementation of that described above formats. I will sum up the last four patches of this series by saying that they add features for emulating DVD-ROM and BD devices. Doing so increases the size of the f_mass_storage driver by a considerable amount and also adds a large amount of new material to Jens Axboe's include/uapi/linux/cdrom.h. Is any of this really needed? What usage scenarios require f_mass_storage to emulate a DVD-ROM that couldn't use f_tcm instead? Alan Stern