From: Johan Hovold <johan@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH 1/6] USB: serial: cp210x: fix control-characters error handling
Date: Fri, 2 Jul 2021 15:42:22 +0200 [thread overview]
Message-ID: <20210702134227.24621-2-johan@kernel.org> (raw)
In-Reply-To: <20210702134227.24621-1-johan@kernel.org>
In the unlikely event that setting the software flow-control characters
fails the other flow-control settings should still be updated.
Fixes: 7748feffcd80 ("USB: serial: cp210x: add support for software flow control")
Cc: stable@vger.kernel.org # 5.11
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/cp210x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 09b845d0da41..b41e2c7649fb 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -1217,9 +1217,7 @@ static void cp210x_set_flow_control(struct tty_struct *tty,
chars.bXonChar = START_CHAR(tty);
chars.bXoffChar = STOP_CHAR(tty);
- ret = cp210x_set_chars(port, &chars);
- if (ret)
- return;
+ cp210x_set_chars(port, &chars);
}
mutex_lock(&port_priv->mutex);
--
2.31.1
next prev parent reply other threads:[~2021-07-02 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 13:42 [PATCH 0/6] USB: serial: cp210x: fixes and CP2105/CP2108 fw version Johan Hovold
2021-07-02 13:42 ` Johan Hovold [this message]
2021-07-02 14:47 ` [PATCH 1/6] USB: serial: cp210x: fix control-characters error handling Greg KH
2021-07-05 7:40 ` Johan Hovold
2021-07-02 13:42 ` [PATCH 2/6] USB: serial: cp210x: fix flow-control " Johan Hovold
2021-07-02 13:42 ` [PATCH 3/6] USB: serial: cp210x: clean up control-request timeout Johan Hovold
2021-07-02 13:42 ` [PATCH 4/6] USB: serial: cp210x: clean up set-chars request Johan Hovold
2021-07-02 13:42 ` [PATCH 5/6] USB: serial: cp210x: clean up type detection Johan Hovold
2021-07-02 13:42 ` [PATCH 6/6] USB: serial: cp210x: determine fw version for CP2105 and CP2108 Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702134227.24621-2-johan@kernel.org \
--to=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).