From: kernel test robot <lkp@intel.com>
To: Laurence Oberman <loberman@redhat.com>,
linux-usb@vger.kernel.org, andriy.shevchenko@linux.intel.com,
stable@vger.kernel.org, emilne@redhat.com, djeffery@redhat.com,
apanagio@redhat.com, torez@redhat.com
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH] usb: hcd: Revert 306c54d0edb6ba94d39877524dddebaad7770cf2: Try MSI interrupts on PCI devices
Date: Wed, 14 Jul 2021 04:30:00 +0800 [thread overview]
Message-ID: <202107140457.un5OWjAx-lkp@intel.com> (raw)
In-Reply-To: <1626202242-14984-1-git-send-email-loberman@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 6299 bytes --]
Hi Laurence,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on peter.chen-usb/for-usb-next balbi-usb/testing/next v5.14-rc1 next-20210713]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Laurence-Oberman/usb-hcd-Revert-306c54d0edb6ba94d39877524dddebaad7770cf2-Try-MSI-interrupts-on-PCI-devices/20210714-025312
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3ea2a748176f21120e150f0645bc3c22e1cea48f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Laurence-Oberman/usb-hcd-Revert-306c54d0edb6ba94d39877524dddebaad7770cf2-Try-MSI-interrupts-on-PCI-devices/20210714-025312
git checkout 3ea2a748176f21120e150f0645bc3c22e1cea48f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/usb/core/hcd-pci.c: In function 'usb_hcd_pci_remove':
>> drivers/usb/core/hcd-pci.c:316:8: warning: variable 'hcd_driver_flags' set but not used [-Wunused-but-set-variable]
316 | int hcd_driver_flags;
| ^~~~~~~~~~~~~~~~
vim +/hcd_driver_flags +316 drivers/usb/core/hcd-pci.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 300
^1da177e4c3f41 Linus Torvalds 2005-04-16 301 /**
^1da177e4c3f41 Linus Torvalds 2005-04-16 302 * usb_hcd_pci_remove - shutdown processing for PCI-based HCDs
^1da177e4c3f41 Linus Torvalds 2005-04-16 303 * @dev: USB Host Controller being removed
41631d3616c363 Ahmed S. Darwish 2020-10-19 304 *
41631d3616c363 Ahmed S. Darwish 2020-10-19 305 * Context: task context, might sleep
^1da177e4c3f41 Linus Torvalds 2005-04-16 306 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 307 * Reverses the effect of usb_hcd_pci_probe(), first invoking
^1da177e4c3f41 Linus Torvalds 2005-04-16 308 * the HCD's stop() method. It is always called from a thread
^1da177e4c3f41 Linus Torvalds 2005-04-16 309 * context, normally "rmmod", "apmd", or something similar.
^1da177e4c3f41 Linus Torvalds 2005-04-16 310 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 311 * Store this function in the HCD's struct pci_driver as remove().
^1da177e4c3f41 Linus Torvalds 2005-04-16 312 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 313 void usb_hcd_pci_remove(struct pci_dev *dev)
^1da177e4c3f41 Linus Torvalds 2005-04-16 314 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 315 struct usb_hcd *hcd;
7b2816dd293031 Andy Shevchenko 2020-08-14 @316 int hcd_driver_flags;
^1da177e4c3f41 Linus Torvalds 2005-04-16 317
^1da177e4c3f41 Linus Torvalds 2005-04-16 318 hcd = pci_get_drvdata(dev);
^1da177e4c3f41 Linus Torvalds 2005-04-16 319 if (!hcd)
^1da177e4c3f41 Linus Torvalds 2005-04-16 320 return;
^1da177e4c3f41 Linus Torvalds 2005-04-16 321
7b2816dd293031 Andy Shevchenko 2020-08-14 322 hcd_driver_flags = hcd->driver->flags;
7b2816dd293031 Andy Shevchenko 2020-08-14 323
3da7cff4e79e4a Alan Stern 2010-06-25 324 if (pci_dev_run_wake(dev))
3da7cff4e79e4a Alan Stern 2010-06-25 325 pm_runtime_get_noresume(&dev->dev);
3da7cff4e79e4a Alan Stern 2010-06-25 326
c548795abe0d35 Alan Stern 2010-06-09 327 /* Fake an interrupt request in order to give the driver a chance
c548795abe0d35 Alan Stern 2010-06-09 328 * to test whether the controller hardware has been removed (e.g.,
c548795abe0d35 Alan Stern 2010-06-09 329 * cardbus physical eject).
c548795abe0d35 Alan Stern 2010-06-09 330 */
c548795abe0d35 Alan Stern 2010-06-09 331 local_irq_disable();
c548795abe0d35 Alan Stern 2010-06-09 332 usb_hcd_irq(0, hcd);
c548795abe0d35 Alan Stern 2010-06-09 333 local_irq_enable();
c548795abe0d35 Alan Stern 2010-06-09 334
05768918b9a122 Alan Stern 2013-03-28 335 /* Note: dev_set_drvdata must be called while holding the rwsem */
05768918b9a122 Alan Stern 2013-03-28 336 if (dev->class == CL_EHCI) {
05768918b9a122 Alan Stern 2013-03-28 337 down_write(&companions_rwsem);
05768918b9a122 Alan Stern 2013-03-28 338 for_each_companion(dev, hcd, ehci_remove);
05768918b9a122 Alan Stern 2013-03-28 339 usb_remove_hcd(hcd);
05768918b9a122 Alan Stern 2013-03-28 340 dev_set_drvdata(&dev->dev, NULL);
05768918b9a122 Alan Stern 2013-03-28 341 up_write(&companions_rwsem);
05768918b9a122 Alan Stern 2013-03-28 342 } else {
05768918b9a122 Alan Stern 2013-03-28 343 /* Not EHCI; just clear the companion pointer */
05768918b9a122 Alan Stern 2013-03-28 344 down_read(&companions_rwsem);
05768918b9a122 Alan Stern 2013-03-28 345 hcd->self.hs_companion = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 346 usb_remove_hcd(hcd);
05768918b9a122 Alan Stern 2013-03-28 347 dev_set_drvdata(&dev->dev, NULL);
05768918b9a122 Alan Stern 2013-03-28 348 up_read(&companions_rwsem);
05768918b9a122 Alan Stern 2013-03-28 349 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 350 usb_put_hcd(hcd);
^1da177e4c3f41 Linus Torvalds 2005-04-16 351 pci_disable_device(dev);
^1da177e4c3f41 Linus Torvalds 2005-04-16 352 }
782e70c6fc2290 Greg Kroah-Hartman 2008-01-25 353 EXPORT_SYMBOL_GPL(usb_hcd_pci_remove);
^1da177e4c3f41 Linus Torvalds 2005-04-16 354
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68516 bytes --]
next prev parent reply other threads:[~2021-07-13 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 18:50 [PATCH] usb: hcd: Revert 306c54d0edb6ba94d39877524dddebaad7770cf2: Try MSI interrupts on PCI devices Laurence Oberman
2021-07-13 19:15 ` Alan Stern
2021-07-13 20:05 ` Laurence Oberman
2021-07-13 20:30 ` Andy Shevchenko
2021-07-13 20:30 ` kernel test robot [this message]
2021-07-13 20:33 ` Andy Shevchenko
2021-07-13 20:44 ` Laurence Oberman
2021-07-13 21:57 ` Laurence Oberman
2021-07-13 23:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107140457.un5OWjAx-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=apanagio@redhat.com \
--cc=djeffery@redhat.com \
--cc=emilne@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-usb@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=stable@vger.kernel.org \
--cc=torez@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox