Re: [PATCH] usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers

Felipe Balbi
2021-07-22T11:49:58Z

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

Maxim Devaev <mdevaev@gmail.com> writes:

> The USB HID standard declares mandatory support for GET_IDLE and SET_IDLE
> requests for Boot Keyboard. Most hosts can handle their absence, but others
> like some old/strange UEFIs and BIOSes consider this a critical error
> and refuse to work with f_hid.
>
> This primitive implementation of saving and returning idle is sufficient
> to meet the requirements of the standard and these devices.
>
> Signed-off-by: Maxim Devaev <mdevaev@gmail.com>

yeah, I don't see any issues with this. If you have access to the tool,
mind running USBCV on the f_hid gadget? Would be cool to get some
confirmation that we're within spec.

That shouldn't gate $subject though.

Acked-by: Felipe Balbi <balbi@kernel.org>

--
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]