From: Dan Carpenter <dan.carpenter@oracle.com>
To: rui.silva@linaro.org
Cc: linux-usb@vger.kernel.org
Subject: [bug report] usb: isp1760: add support for isp1763
Date: Mon, 26 Jul 2021 10:28:25 +0300 [thread overview]
Message-ID: <20210726072825.GA9005@kili> (raw)
Hello Rui Miguel Silva,
The patch 60d789f3bfbb: "usb: isp1760: add support for isp1763" from
May 13, 2021, leads to the following static checker warning:
drivers/usb/isp1760/isp1760-hcd.c:276 isp1760_hcd_clear_and_wait()
warn: sleeping in atomic context
drivers/usb/isp1760/isp1760-hcd.c
268 static int isp1760_hcd_clear_and_wait(struct usb_hcd *hcd, u32 field,
269 u32 timeout_us)
270 {
271 struct isp1760_hcd *priv = hcd_to_priv(hcd);
272 u32 val;
273
274 isp1760_hcd_clear(hcd, field);
275
--> 276 return regmap_field_read_poll_timeout(priv->fields[field], val,
277 !val, 10, timeout_us);
^^
Originally this used to call read_poll_timeout() with 0 us_timeout (no
sleeping). The caller always holds a spin_lock.
278 }
regards,
dan carpenter
reply other threads:[~2021-07-26 7:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726072825.GA9005@kili \
--to=dan.carpenter@oracle.com \
--cc=linux-usb@vger.kernel.org \
--cc=rui.silva@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox