From: Jeaho Hwang <jhhwang@rtst.co.kr>
To: Peter Chen <peter.chen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: [PATCH] usb: chipidea: fix RT issue for udc
Date: Tue, 10 Aug 2021 15:02:28 +0900 [thread overview]
Message-ID: <20210810060228.GA3326442@ubuntu> (raw)
hw_ep_prime sometimes fails if irq occurs while it rus on RT kernel.
to prevent local_irq_save should keep the function from irqs.
I am not sure where is the best to submit this patch, between RT and USB
community so sending to both. thanks.
Signed-off-by: Jeaho Hwang <jhhwang@rtst.co.kr>
---
drivers/usb/chipidea/udc.c | 31 +++++++++++++++++++++++++------
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 5f35cdd2cf1d..a90498f17cc4 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -102,6 +102,9 @@ static int hw_ep_flush(struct ci_hdrc *ci, int num, int dir)
{
int n = hw_ep_bit(num, dir);
+ /* From zynq-7000 TRM, It can take a long time
+ * so irq disable is not a good option for RT
+ */
do {
/* flush any pending transfer */
hw_write(ci, OP_ENDPTFLUSH, ~0, BIT(n));
@@ -190,22 +193,32 @@ static int hw_ep_get_halt(struct ci_hdrc *ci, int num, int dir)
static int hw_ep_prime(struct ci_hdrc *ci, int num, int dir, int is_ctrl)
{
int n = hw_ep_bit(num, dir);
+ unsigned long flags;
+ int ret = 0;
/* Synchronize before ep prime */
wmb();
- if (is_ctrl && dir == RX && hw_read(ci, OP_ENDPTSETUPSTAT, BIT(num)))
- return -EAGAIN;
+ /* irq affects this routine so irq should be disabled on RT.
+ * on standard kernel, irq is already disabled by callers.
+ */
+ local_irq_save(flags);
+ if (is_ctrl && dir == RX && hw_read(ci, OP_ENDPTSETUPSTAT, BIT(num))) {
+ ret = -EAGAIN;
+ goto out;
+ }
hw_write(ci, OP_ENDPTPRIME, ~0, BIT(n));
while (hw_read(ci, OP_ENDPTPRIME, BIT(n)))
cpu_relax();
if (is_ctrl && dir == RX && hw_read(ci, OP_ENDPTSETUPSTAT, BIT(num)))
- return -EAGAIN;
+ ret = -EAGAIN;
+out:
+ local_irq_restore(flags);
/* status shoult be tested according with manual but it doesn't work */
- return 0;
+ return ret;
}
/**
--
2.25.1
next reply other threads:[~2021-08-10 6:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 6:02 Jeaho Hwang [this message]
2021-08-13 7:08 ` [PATCH] usb: chipidea: fix RT issue for udc Greg Kroah-Hartman
2021-08-16 0:52 ` Peter Chen
2021-08-16 1:03 ` Alan Stern
2021-08-16 3:52 ` Jeaho Hwang
2021-08-16 5:22 ` Greg Kroah-Hartman
2021-08-16 7:10 ` Jeaho Hwang
2021-08-16 7:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810060228.GA3326442@ubuntu \
--to=jhhwang@rtst.co.kr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox