From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD84C433F5 for ; Tue, 7 Sep 2021 14:13:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E76B461107 for ; Tue, 7 Sep 2021 14:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235766AbhIGOPB (ORCPT ); Tue, 7 Sep 2021 10:15:01 -0400 Received: from netrider.rowland.org ([192.131.102.5]:56417 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S235435AbhIGOPA (ORCPT ); Tue, 7 Sep 2021 10:15:00 -0400 Received: (qmail 571841 invoked by uid 1000); 7 Sep 2021 10:13:52 -0400 Date: Tue, 7 Sep 2021 10:13:52 -0400 From: Alan Stern To: Guenter Roeck Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: ehci: Simplify platform driver registration Message-ID: <20210907141352.GA571275@rowland.harvard.edu> References: <20210907123002.3951446-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210907123002.3951446-1-linux@roeck-us.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Sep 07, 2021 at 05:30:02AM -0700, Guenter Roeck wrote: > Use platform_register_drivers() and platform_unregister_drivers() to > register and unregister ehci platform drivers. This simplifies the code > and prevents the following build errors seen with sparc:allmodconfig. > > drivers/usb/host/ehci-hcd.c:1301: error: > "PLATFORM_DRIVER" redefined > drivers/usb/host/ehci-sh.c:173:31: error: > 'ehci_hcd_sh_driver' defined but not used > > Signed-off-by: Guenter Roeck > --- > v2: Explicitly include platform_device.h. > The ps3 driver is not a platform driver, so we still have > to handle it separately. Acked-by: Alan Stern