From: Oliver Neukum <oneukum@suse.com>
To: syzkaller-bugs@googlegroups.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Cc: Oliver Neukum <oneukum@suse.com>,
syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
Subject: [PATCH] usbnet: sanity check for maxpacket
Date: Wed, 20 Oct 2021 11:17:33 +0200 [thread overview]
Message-ID: <20211020091733.20085-1-oneukum@suse.com> (raw)
maxpacket of 0 makes no sense and oopdses as we need to divide
by it. Give up.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
---
drivers/net/usb/usbnet.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 840c1c2ab16a..396f5e677bf0 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1788,6 +1788,9 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
if (!dev->rx_urb_size)
dev->rx_urb_size = dev->hard_mtu;
dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
+ if (dev->maxpacket == 0)
+ /* that is a broken device */
+ goto out4;
/* let userspace know we have a random address */
if (ether_addr_equal(net->dev_addr, node_id))
--
2.26.2
next reply other threads:[~2021-10-20 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 9:17 Oliver Neukum [this message]
2021-10-20 10:32 ` [PATCH] usbnet: sanity check for maxpacket Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020091733.20085-1-oneukum@suse.com \
--to=oneukum@suse.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox