[PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with temp

[PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with temp

[Haimin Zhang]

In function `ehci_brcm_hub_control`, like following code,  
it filters out the case where the upper byte of wIndex is nonzero, 
so it need be replaced with temp.
```
	if ((typeReq == GetPortStatus) &&
	    (wIndex && wIndex <= ports) &&       // need to be replaced
	    ehci->reset_done[wIndex-1] &&
	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
	    (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
```

Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
Reported-by: TCS Robot <tcs_robot@tencent.com>
---
 drivers/usb/host/ehci-brcm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c
index a1e3290e5459..efcfca162126 100644
--- a/drivers/usb/host/ehci-brcm.c
+++ b/drivers/usb/host/ehci-brcm.c
@@ -73,9 +73,9 @@ static int ehci_brcm_hub_control(
 	 * of RESUME
 	 */
 	if ((typeReq == GetPortStatus) &&
-	    (wIndex && wIndex <= ports) &&
-	    ehci->reset_done[wIndex-1] &&
-	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
+	    (temp < ports) &&
+	    ehci->reset_done[temp] &&
+	    time_after_eq(jiffies, ehci->reset_done[temp]) &&
 	    (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
 
 		/*
-- 
2.30.1 (Apple Git-130)

Re: [PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with temp

[Greg KH]

On Fri, Nov 05, 2021 at 04:33:57PM +0800, Haimin Zhang wrote:
> In function `ehci_brcm_hub_control`, like following code,  
> it filters out the case where the upper byte of wIndex is nonzero, 
> so it need be replaced with temp.

I do not understand this text, can you try to reword it?

And you have trailing whitespace.

And why use `?

> ```

What is this for?  Changelog comments are not in markdown format.

> 	if ((typeReq == GetPortStatus) &&
> 	    (wIndex && wIndex <= ports) &&       // need to be replaced

What does this comment mean?

> 	    ehci->reset_done[wIndex-1] &&
> 	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
> 	    (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
> ```
> 
> Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
> Reported-by: TCS Robot <tcs_robot@tencent.com>

Again, lines need to be in different order, and your from: line is not
correct.

Also, you need an individual email address, not a group email alias for
your contributions.  We work with individuals, not groups.



> ---
>  drivers/usb/host/ehci-brcm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c
> index a1e3290e5459..efcfca162126 100644
> --- a/drivers/usb/host/ehci-brcm.c
> +++ b/drivers/usb/host/ehci-brcm.c
> @@ -73,9 +73,9 @@ static int ehci_brcm_hub_control(
>  	 * of RESUME
>  	 */
>  	if ((typeReq == GetPortStatus) &&
> -	    (wIndex && wIndex <= ports) &&
> -	    ehci->reset_done[wIndex-1] &&
> -	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
> +	    (temp < ports) &&

Where did temp come from?

thanks,

greg k-h

Re: [PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with temp

[Alan Stern]

On Fri, Nov 05, 2021 at 09:52:13AM +0100, Greg KH wrote:
> On Fri, Nov 05, 2021 at 04:33:57PM +0800, Haimin Zhang wrote:
> > In function `ehci_brcm_hub_control`, like following code,  
> > it filters out the case where the upper byte of wIndex is nonzero, 
> > so it need be replaced with temp.
> 
> I do not understand this text, can you try to reword it?
> 
> And you have trailing whitespace.
> 
> And why use `?
> 
> > ```
> 
> What is this for?  Changelog comments are not in markdown format.
> 
> > 	if ((typeReq == GetPortStatus) &&
> > 	    (wIndex && wIndex <= ports) &&       // need to be replaced
> 
> What does this comment mean?
> 
> > 	    ehci->reset_done[wIndex-1] &&
> > 	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
> > 	    (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
> > ```
> > 
> > Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
> > Reported-by: TCS Robot <tcs_robot@tencent.com>
> 
> Again, lines need to be in different order, and your from: line is not
> correct.
> 
> Also, you need an individual email address, not a group email alias for
> your contributions.  We work with individuals, not groups.
> 
> 
> 
> > ---
> >  drivers/usb/host/ehci-brcm.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c
> > index a1e3290e5459..efcfca162126 100644
> > --- a/drivers/usb/host/ehci-brcm.c
> > +++ b/drivers/usb/host/ehci-brcm.c
> > @@ -73,9 +73,9 @@ static int ehci_brcm_hub_control(
> >  	 * of RESUME
> >  	 */
> >  	if ((typeReq == GetPortStatus) &&
> > -	    (wIndex && wIndex <= ports) &&
> > -	    ehci->reset_done[wIndex-1] &&
> > -	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
> > +	    (temp < ports) &&
> 
> Where did temp come from?

Also, as long as this piece of code is being changed, it would be a good 
idea to get rid of all the unnecessary parentheses.

Alan Stern

Re: [PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with temp

[Florian Fainelli]

On 11/5/21 1:52 AM, Greg KH wrote:
> On Fri, Nov 05, 2021 at 04:33:57PM +0800, Haimin Zhang wrote:
>> In function `ehci_brcm_hub_control`, like following code,  
>> it filters out the case where the upper byte of wIndex is nonzero, 
>> so it need be replaced with temp.
> 
> I do not understand this text, can you try to reword it?
> 
> And you have trailing whitespace.
> 
> And why use `?
> 
>> ```
> 
> What is this for?  Changelog comments are not in markdown format.
> 
>> 	if ((typeReq == GetPortStatus) &&
>> 	    (wIndex && wIndex <= ports) &&       // need to be replaced
> 
> What does this comment mean?
> 
>> 	    ehci->reset_done[wIndex-1] &&
>> 	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
>> 	    (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
>> ```
>>
>> Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
>> Reported-by: TCS Robot <tcs_robot@tencent.com>
> 
> Again, lines need to be in different order, and your from: line is not
> correct.
> 
> Also, you need an individual email address, not a group email alias for
> your contributions.  We work with individuals, not groups.

Also, would you mind copying the people who are remotely involved with
this piece of code, like Al? Thank you
-- 
Florian