From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Guenter Roeck <linux@roeck-us.net>,
Sebastian Reichel <sre@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Hans de Goede <hdegoede@redhat.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] extcon: fix extcon_get_extcon_dev() error handling
Date: Thu, 16 Dec 2021 10:52:33 +0300 [thread overview]
Message-ID: <20211216075233.GD1978@kadam> (raw)
In-Reply-To: <562b12ff-e395-c818-787e-7fd6ee6d53fb@samsung.com>
On Thu, Dec 16, 2021 at 03:39:46PM +0900, Chanwoo Choi wrote:
> Hi Dan,
>
> First of all, sorry for late reply.
>
> There is one issue. About this issue, I already discussed on patch[1]
> [1] https://lore.kernel.org/lkml/5BEB63C3.1020504@samsung.com/
>
> extcon_get_extcon_dev() is used for anywhere except for probe step.
> But EPROBE_DEFER is only used on probe step.
>
> So that it is not clear to return EPROBE_DEFER from extcon_get_extcon_dev()
> because extcon_get_extcon_dev() never know either call it on probe function
> or not.
Currently extcon_get_extcon_dev() is only called from probe so it's not
an issue.
It's impossible to know what future programmers will want, but I feel
like this change probably makes it easier for them.
regards,
dan carpenter
next prev parent reply other threads:[~2021-12-16 7:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211123084357epcas1p14833147710153f9606f14941ac8b0d96@epcas1p1.samsung.com>
2021-11-23 8:43 ` [PATCH v2] extcon: fix extcon_get_extcon_dev() error handling Dan Carpenter
2021-11-23 14:14 ` Hans de Goede
2021-11-23 14:48 ` Guenter Roeck
2021-11-23 15:20 ` Heikki Krogerus
2021-12-16 6:39 ` Chanwoo Choi
2021-12-16 7:52 ` Dan Carpenter [this message]
2021-12-16 8:24 ` Chanwoo Choi
2021-12-16 8:05 ` Dan Carpenter
2021-12-16 8:38 ` Chanwoo Choi
2021-12-16 15:59 ` Dan Carpenter
2021-12-17 1:31 ` Chanwoo Choi
2021-12-16 9:08 ` Hans de Goede
2021-12-17 6:28 ` [PATCH v3] " Dan Carpenter
2021-12-20 1:20 ` Chanwoo Choi
2022-02-03 5:24 ` Chanwoo Choi
2022-02-16 1:12 ` Chanwoo Choi
2022-01-03 17:46 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211216075233.GD1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=balbi@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox