From: Peter Chen <peter.chen@kernel.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: cdnsp: remove not used temp_64 variables
Date: Wed, 12 Jan 2022 21:02:01 +0800 [thread overview]
Message-ID: <20220112130201.GE3796@Peter> (raw)
In-Reply-To: <20220111114449.44402-1-pawell@gli-login.cadence.com>
On 22-01-11 12:44:49, Pawel Laszczak wrote:
> From: Pawel Laszczak <pawell@cadence.com>
>
> Patch removes initialized but not used variables temp_64
> from cdnsp_run function.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Reviewed-by: Peter Chen <peter.chen@kernel.org>
> ---
> drivers/usb/cdns3/cdnsp-gadget.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-gadget.c
> index 27df0c697897..ec8a0dc792bc 100644
> --- a/drivers/usb/cdns3/cdnsp-gadget.c
> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
> @@ -1243,12 +1243,9 @@ static int cdnsp_run(struct cdnsp_device *pdev,
> enum usb_device_speed speed)
> {
> u32 fs_speed = 0;
> - u64 temp_64;
> u32 temp;
> int ret;
>
> - temp_64 = cdnsp_read_64(&pdev->ir_set->erst_dequeue);
> - temp_64 &= ~ERST_PTR_MASK;
> temp = readl(&pdev->ir_set->irq_control);
> temp &= ~IMOD_INTERVAL_MASK;
> temp |= ((IMOD_DEFAULT_INTERVAL / 250) & IMOD_INTERVAL_MASK);
> --
> 2.25.1
>
--
Thanks,
Peter Chen
prev parent reply other threads:[~2022-01-12 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 11:44 [PATCH] usb: cdnsp: remove not used temp_64 variables Pawel Laszczak
2022-01-12 13:02 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112130201.GE3796@Peter \
--to=peter.chen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).