From: Lukas Wunner <lukas@wunner.de>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
<nouveau@lists.freedesktop.org>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Alexander.Deucher@amd.com, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`
Date: Tue, 15 Feb 2022 08:29:11 +0100 [thread overview]
Message-ID: <20220215072911.GA13892@wunner.de> (raw)
In-Reply-To: <20220215000200.242799-1-mario.limonciello@amd.com>
On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote:
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +-
> drivers/gpu/drm/radeon/radeon_device.c | 4 +-
> drivers/gpu/drm/radeon/radeon_kms.c | 2 +-
> drivers/pci/hotplug/pciehp_hpc.c | 6 +-
> drivers/pci/pci-acpi.c | 15 ++++-
> drivers/pci/pci.c | 17 +++--
> drivers/pci/probe.c | 52 ++++++++++++++-
> drivers/pci/quirks.c | 84 +++++++++++++++++++++++++
> drivers/platform/x86/apple-gmux.c | 2 +-
> drivers/thunderbolt/nhi.h | 2 -
> include/linux/pci.h | 25 +-------
> include/linux/pci_ids.h | 3 +
> 14 files changed, 173 insertions(+), 47 deletions(-)
That's an awful lot of additional LoC for what is primarily
a refactoring job with the intent to simplify things.
Honestly this looks like an attempt to fix something that
isn't broken. Specifically, the is_thunderbolt bit apparently
can't be removed without adding new bits to struct pci_dev.
Not sure if that can be called progress.
Thanks,
Lukas
next prev parent reply other threads:[~2022-02-15 7:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 0:01 [PATCH v4 00/10] Overhaul `is_thunderbolt` Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 01/10] PCI: Add USB4 class definition Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 02/10] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 03/10] PCI: Detect root port of internal USB4 controllers Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 04/10] PCI: Detect PCIe root ports for discrete " Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 05/10] PCI: Move check for old Apple Thunderbolt controllers into a quirk Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 06/10] PCI: Drop the `is_thunderbolt` attribute from PCI core Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 07/10] drm/amd: drop the use of `pci_is_thunderbolt_attached` Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 08/10] drm/nouveau: " Mario Limonciello
2022-02-15 0:01 ` [PATCH v4 09/10] drm/radeon: " Mario Limonciello
2022-02-15 0:02 ` [PATCH v4 10/10] PCI: drop `pci_is_thunderbolt_attached` Mario Limonciello
2022-02-15 7:29 ` Lukas Wunner [this message]
2022-02-15 19:07 ` [PATCH v4 00/10] Overhaul `is_thunderbolt` Limonciello, Mario
2022-02-16 14:34 ` Mika Westerberg
2022-02-16 14:44 ` Alex Deucher
2022-02-16 16:50 ` Limonciello, Mario
2022-02-17 9:33 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215072911.GA13892@wunner.de \
--to=lukas@wunner.de \
--cc=Alexander.Deucher@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox