From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052B5C433EF for ; Sun, 20 Mar 2022 12:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245030AbiCTMG1 (ORCPT ); Sun, 20 Mar 2022 08:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245043AbiCTMGY (ORCPT ); Sun, 20 Mar 2022 08:06:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A7F56377C9 for ; Sun, 20 Mar 2022 05:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647777900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dluyFNWHj0wdqGZD9WiZi8hb8qI80pWjkbX+xynrT7U=; b=NatXzc0l1hN+DWDEjPhDLQWVCskvBWypGy0/f3JsM9la9Fem8I1WVXP33pw+FTDZ8EuMdk ecThVAuHL7OiXJFuy4MV+aaotNm88zM6FWkAPaVh3A77efiyU6Zz2Qk1S062nUElNwFZ3i XJRCrJqBaQxcHKASe9+UIymvmIj7i/Y= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-77-Pf8BOrWlOMiKpMdMwStIXw-1; Sun, 20 Mar 2022 08:04:59 -0400 X-MC-Unique: Pf8BOrWlOMiKpMdMwStIXw-1 Received: by mail-ej1-f69.google.com with SMTP id gx12-20020a1709068a4c00b006df7e8181ceso5671895ejc.10 for ; Sun, 20 Mar 2022 05:04:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dluyFNWHj0wdqGZD9WiZi8hb8qI80pWjkbX+xynrT7U=; b=FXSrvjAoxX4vJcLTMnM4FsKwjS7p/ctVFPDEL1H1VTf3HaWQss+/pOJhAVBRqcxRbI 16Uhxbx2uRvIKaYaTmUoub+pC9KjWdTOUYr6bMg5Neo2QFcnE5BcB5DDtTDgh6Yu1vhK 28m0HGW8h+hrRMCpACAtnXb3Y97lwXsv49o9eAuQbhfGtGf4FoeJfutQJmg1DJU115gT TUPz/EuSZ3mMWZrvU+iETIgGoOq5ExpACq7qNIvonBzMSNhaV52F0zF+YY0akVCtnGJV lAWkHpCd/WTo5PIez8oMfNJdyph6Iro7m7l/jOqwroJ+2Ls6Xm2SADU6zMcbisddjakj cEVg== X-Gm-Message-State: AOAM531om261Ulm93U5GnZ0lJlaLwqzT/MBynBo8sLe6hqH87kM/nyIM HtbKdxZHy0P1fT+NCkxTtLusGrDk8Qy1n5+ZdvN9xPbXfEpkpxk+5xoNxBjp0FAT+owoAbZOG3B nMs3gmtYAYG/GQBQo5GbH X-Received: by 2002:a05:6402:40c5:b0:418:e73c:a1ab with SMTP id z5-20020a05640240c500b00418e73ca1abmr18517083edb.52.1647777898164; Sun, 20 Mar 2022 05:04:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfAQhzmlNy6q9yY+EnFX+2g1gYETe+axmQh3kzhVOc32at9/0TqUx+j50nzMAK4FS++1BWlA== X-Received: by 2002:a05:6402:40c5:b0:418:e73c:a1ab with SMTP id z5-20020a05640240c500b00418e73ca1abmr18517008edb.52.1647777897820; Sun, 20 Mar 2022 05:04:57 -0700 (PDT) Received: from redhat.com ([2.55.132.0]) by smtp.gmail.com with ESMTPSA id 27-20020a17090600db00b006df6b34d9b8sm5854831eji.211.2022.03.20.05.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 05:04:57 -0700 (PDT) Date: Sun, 20 Mar 2022 08:04:48 -0400 From: "Michael S. Tsirkin" To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Jens Axboe , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Eli Cohen , Saeed Mahameed , Leon Romanovsky , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Sebastian Andrzej Siewior , Krzysztof Opasiak , Igor Kotrasinski , Valentina Manea , Shuah Khan , Shuah Khan , Jussi Kivilinna , Joachim Fritschi , Herbert Xu , Thomas Gleixner , Steven Rostedt , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit Message-ID: <20220320080438-mutt-send-email-mst@kernel.org> References: <20220316192010.19001-1-rdunlap@infradead.org> <20220316192010.19001-3-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220316192010.19001-3-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Mar 16, 2022 at 12:20:03PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > > Fixes: 31610434bc35 ("Virtio console driver") > Fixes: 7177876fea83 ("virtio: console: Add ability to remove module") > Signed-off-by: Randy Dunlap > Cc: Amit Shah > Cc: virtualization@lists.linux-foundation.org > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman If this is done tree-wide, it's ok to do it for virtio too. Acked-by: Michael S. Tsirkin No real opinion on whether it's a good idea. > --- > drivers/char/virtio_console.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- lnx-517-rc8.orig/drivers/char/virtio_console.c > +++ lnx-517-rc8/drivers/char/virtio_console.c > @@ -2245,7 +2245,7 @@ static struct virtio_driver virtio_rproc > .remove = virtcons_remove, > }; > > -static int __init init(void) > +static int __init virtio_console_init(void) > { > int err; > > @@ -2280,7 +2280,7 @@ free: > return err; > } > > -static void __exit fini(void) > +static void __exit virtio_console_fini(void) > { > reclaim_dma_bufs(); > > @@ -2290,8 +2290,8 @@ static void __exit fini(void) > class_destroy(pdrvdata.class); > debugfs_remove_recursive(pdrvdata.debugfs_dir); > } > -module_init(init); > -module_exit(fini); > +module_init(virtio_console_init); > +module_exit(virtio_console_fini); > > MODULE_DESCRIPTION("Virtio console driver"); > MODULE_LICENSE("GPL");