From: Jules Maselbas <jmaselbas@kalray.eu>
To: linux-usb@vger.kernel.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Minas Harutyunyan <hminas@synopsys.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Amelie DELAUNAY <amelie.delaunay@foss.st.com>,
Yann Sionneau <ysionneau@kalray.eu>,
Michael Grzeschik <mgr@pengutronix.de>,
Jules Maselbas <jmaselbas@kalray.eu>
Subject: [PATCH 0/2] Cleanup the call ordering of phy_init and phy_power_on
Date: Tue, 22 Mar 2022 15:30:09 +0100 [thread overview]
Message-ID: <20220322143011.16580-1-jmaselbas@kalray.eu> (raw)
Hi,
Last year Ahmad asked what is the correct order when calling phy_init
and phy_power_on. Since then, I didn't see the situation improve much
and I am once again toying around with usb phy driver.
The following two patches were in my tree for a year... Last year i
previously tried to change the call order in the dwc2 driver but this
requires the relevent phy to be also compatible with the "new" ordering.
The stm32-usbphyc driver wasn't compatible, I am not sure if that is
still is the case.
For now simply add documentation, hopefully correct, but I am not an
expert on actual phy sementics or usage in the kernel. And add warning
when the order is not what's expected.
Best,
Jules Maselbas (2):
phy: core: Add documentation of phy operation order
phy: core: Warn when phy_power_on is called before phy_init
drivers/phy/phy-core.c | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
--
2.17.1
next reply other threads:[~2022-03-22 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 14:30 Jules Maselbas [this message]
2022-03-22 14:30 ` [PATCH 1/2] phy: core: Add documentation of phy operation order Jules Maselbas
2022-03-22 19:46 ` Randy Dunlap
2022-03-22 14:30 ` [PATCH 2/2] phy: core: Warn when phy_power_on is called before phy_init Jules Maselbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322143011.16580-1-jmaselbas@kalray.eu \
--to=jmaselbas@kalray.eu \
--cc=a.fatoum@pengutronix.de \
--cc=amelie.delaunay@foss.st.com \
--cc=hminas@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-usb@vger.kernel.org \
--cc=mgr@pengutronix.de \
--cc=ysionneau@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).