From: Jules Maselbas <jmaselbas@kalray.eu>
To: linux-usb@vger.kernel.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Minas Harutyunyan <hminas@synopsys.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Amelie DELAUNAY <amelie.delaunay@foss.st.com>,
Yann Sionneau <ysionneau@kalray.eu>,
Michael Grzeschik <mgr@pengutronix.de>,
Jules Maselbas <jmaselbas@kalray.eu>
Subject: [PATCH 2/2] phy: core: Warn when phy_power_on is called before phy_init
Date: Tue, 22 Mar 2022 15:30:11 +0100 [thread overview]
Message-ID: <20220322143011.16580-3-jmaselbas@kalray.eu> (raw)
In-Reply-To: <20220322143011.16580-1-jmaselbas@kalray.eu>
A warning when the order of phy operation is mixed up by drivers,
this is an atempt to make the phy usage more uniform across (usb)
drivers.
CC: Ahmad Fatoum <a.fatoum@pengutronix.de>
CC: Amelie DELAUNAY <amelie.delaunay@foss.st.com>
Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
drivers/phy/phy-core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index ed10cbb24b08..2c2c0f073080 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -252,6 +252,9 @@ int phy_init(struct phy *phy)
return ret;
ret = 0; /* Override possible ret == -ENOTSUPP */
+ if (phy->power_count > phy->init_count)
+ dev_warn(&phy->dev, "phy_power_on was called before phy_init\n");
+
mutex_lock(&phy->mutex);
if (phy->init_count == 0 && phy->ops->init) {
ret = phy->ops->init(phy);
--
2.17.1
prev parent reply other threads:[~2022-03-22 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 14:30 [PATCH 0/2] Cleanup the call ordering of phy_init and phy_power_on Jules Maselbas
2022-03-22 14:30 ` [PATCH 1/2] phy: core: Add documentation of phy operation order Jules Maselbas
2022-03-22 19:46 ` Randy Dunlap
2022-03-22 14:30 ` Jules Maselbas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322143011.16580-3-jmaselbas@kalray.eu \
--to=jmaselbas@kalray.eu \
--cc=a.fatoum@pengutronix.de \
--cc=amelie.delaunay@foss.st.com \
--cc=hminas@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-usb@vger.kernel.org \
--cc=mgr@pengutronix.de \
--cc=ysionneau@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).