From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79985C433EF for ; Fri, 1 Apr 2022 14:38:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347847AbiDAOkb (ORCPT ); Fri, 1 Apr 2022 10:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347557AbiDAOjc (ORCPT ); Fri, 1 Apr 2022 10:39:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A54F225844F; Fri, 1 Apr 2022 07:33:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29EC0B82500; Fri, 1 Apr 2022 14:33:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C0A1C34115; Fri, 1 Apr 2022 14:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648823612; bh=SyTOn7y6nyPh5CZweMHgg1YlsPXWzamM40RkWEELlmY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z5QGccb5E3hsVxKS+Eohqsem2Iv43rTwOah8k4XrbUzZllYhHWYls8GEqGRfA4/wV bnIkw7BYRyFwXk66KkkWQJ2v0XznfGhCx0Pw3RYH/0Hyrc2S27zZ9ap+88/V3BJD6d cfRrT++vxmpRcjiAXaKu+hf0d9hq81Cj0YSPbeqNcUm8uu/qOzMjVMCdfPz1QoAu53 dczaQ4/G+vd4heB8hfjigr6U4IP8iR19287nqqe6AC4bqn/PwM9NJn8ehgVFKJ5O7F 6tGE9w0dnHLQDQ6z2AjUg/wHKyAAbGPYZgFOwRhKoNJ4jBGRFRpC3KyZ2rtxM1x6hX vxwMb6AYQoGqw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wayne Chang , Greg Kroah-Hartman , Sasha Levin , balbi@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, rikard.falkeborn@gmail.com, chunfeng.yun@mediatek.com, yangyingliang@huawei.com, jakobkoschel@gmail.com, linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH AUTOSEL 5.16 010/109] usb: gadget: tegra-xudc: Do not program SPARAM Date: Fri, 1 Apr 2022 10:31:17 -0400 Message-Id: <20220401143256.1950537-10-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220401143256.1950537-1-sashal@kernel.org> References: <20220401143256.1950537-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Wayne Chang [ Upstream commit 62fb61580eb48fc890b7bc9fb5fd263367baeca8 ] According to the Tegra Technical Reference Manual, SPARAM is a read-only register and should not be programmed in the driver. The change removes the wrong SPARAM usage. Signed-off-by: Wayne Chang Link: https://lore.kernel.org/r/20220107090443.149021-1-waynec@nvidia.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/tegra-xudc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c index 43f1b0d461c1..716d9ab2d2ff 100644 --- a/drivers/usb/gadget/udc/tegra-xudc.c +++ b/drivers/usb/gadget/udc/tegra-xudc.c @@ -32,9 +32,6 @@ #include /* XUSB_DEV registers */ -#define SPARAM 0x000 -#define SPARAM_ERSTMAX_MASK GENMASK(20, 16) -#define SPARAM_ERSTMAX(x) (((x) << 16) & SPARAM_ERSTMAX_MASK) #define DB 0x004 #define DB_TARGET_MASK GENMASK(15, 8) #define DB_TARGET(x) (((x) << 8) & DB_TARGET_MASK) @@ -3295,11 +3292,6 @@ static void tegra_xudc_init_event_ring(struct tegra_xudc *xudc) unsigned int i; u32 val; - val = xudc_readl(xudc, SPARAM); - val &= ~(SPARAM_ERSTMAX_MASK); - val |= SPARAM_ERSTMAX(XUDC_NR_EVENT_RINGS); - xudc_writel(xudc, val, SPARAM); - for (i = 0; i < ARRAY_SIZE(xudc->event_ring); i++) { memset(xudc->event_ring[i], 0, XUDC_EVENT_RING_SIZE * sizeof(*xudc->event_ring[i])); -- 2.34.1