From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: joro@8bytes.org, baolu.lu@linux.intel.com,
andreas.noever@gmail.com, michael.jamet@intel.com,
mika.westerberg@linux.intel.com, YehezkelShB@gmail.com,
iommu@lists.linux-foundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, mario.limonciello@amd.com,
hch@lst.de
Subject: Re: [PATCH v3 1/4] iommu: Introduce device_iommu_capable()
Date: Wed, 6 Apr 2022 07:28:12 +0200 [thread overview]
Message-ID: <20220406052812.GA10507@lst.de> (raw)
In-Reply-To: <37ec2f9f67098d0caf60dcec558fbe1756ea2621.1649089693.git.robin.murphy@arm.com>
On Tue, Apr 05, 2022 at 11:41:01AM +0100, Robin Murphy wrote:
> iommu_capable() only really works for systems where all IOMMU instances
> are completely homogeneous, and all devices are IOMMU-mapped. Implement
> the new variant which can give an accurate answer for whichever device
> the caller is actually interested in.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> v3: New patch; now that the dev_iommu_ops() work has landed we can go
> straight to a proper implementation. Also s/dev/device/ to match
> the precedent of device_iommu_mapped() for the public API.
I'm a little worrited about a method with a parameter than can be
NULL.
Also usnic, vmd, and vdpa really want to use your new
device_iommu_capable as they check based on a device. Just VFIO
is special as usual..
next prev parent reply other threads:[~2022-04-06 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 10:41 [PATCH v3 0/4] thunderbolt: Make iommu_dma_protection more accurate Robin Murphy
2022-04-05 10:41 ` [PATCH v3 1/4] iommu: Introduce device_iommu_capable() Robin Murphy
2022-04-06 5:28 ` Christoph Hellwig [this message]
2022-04-06 10:32 ` Robin Murphy
2022-04-05 10:41 ` [PATCH v3 2/4] iommu: Add capability for pre-boot DMA protection Robin Murphy
2022-04-06 10:28 ` Lu Baolu
2022-04-05 10:41 ` [PATCH v3 3/4] thunderbolt: Make iommu_dma_protection more accurate Robin Murphy
2022-04-05 12:09 ` Mika Westerberg
2022-04-05 10:41 ` [PATCH v3 4/4] iommu/amd: Indicate whether DMA remap support is enabled Robin Murphy
2022-04-06 5:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406052812.GA10507@lst.de \
--to=hch@lst.de \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).