From: paul.elder@ideasonboard.com
To: "Haifeng" <haifeng.li@timesintelli.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]usb: gadget: musb: Fix the DMA transfer error for Isochronous transfers
Date: Wed, 20 Apr 2022 16:08:17 +0900 [thread overview]
Message-ID: <20220420070817.GC3237525@pyrite.rasen.tech> (raw)
In-Reply-To: <001401d85247$2c66cd40$853467c0$@timesintelli.com>
Hello Haifeng,
On Sun, Apr 17, 2022 at 06:37:44PM +0800, Haifeng wrote:
> For Isochronous transfer mode, the ISO bit should be kept in CSR.
> Otherwise, the DMA transfer will be terminated unexpected since
> the ISO bit is missed once the last packet is a short packet.
>
> Signed-off-by: Haifeng Li <haifeng.li@timesintelli.com>
Looks good to me.
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> drivers/usb/musb/musb_gadget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
> index 51274b87f46c..b99faf627dce 100644
> --- a/drivers/usb/musb/musb_gadget.c
> +++ b/drivers/usb/musb/musb_gadget.c
> @@ -482,7 +482,7 @@ void musb_g_tx(struct musb *musb, u8 epnum)
> if (csr & MUSB_TXCSR_TXPKTRDY)
> return;
>
> - musb_writew(epio, MUSB_TXCSR, MUSB_TXCSR_MODE
> + musb_writew(epio, MUSB_TXCSR, csr | MUSB_TXCSR_MODE
> | MUSB_TXCSR_TXPKTRDY);
> request->zero = 0;
> }
> --
> 2.17.1
>
parent reply other threads:[~2022-04-20 7:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <001401d85247$2c66cd40$853467c0$@timesintelli.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420070817.GC3237525@pyrite.rasen.tech \
--to=paul.elder@ideasonboard.com \
--cc=haifeng.li@timesintelli.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox