From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
Alan Stern <stern@rowland.harvard.edu>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Rajat Jain <rajatja@google.com>, Andrew Lunn <andrew@lunn.ch>,
Chris Chiu <chris.chiu@canonical.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Naveen kumar Sunkari <naveenkumar.sunkari@in.bosch.com>,
Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>,
Eugeniu Rosca <rosca.eugeniu@gmail.com>
Subject: Re: [PATCH] usb: hub: Simplify error and success path in port_over_current_notify
Date: Thu, 12 May 2022 17:44:31 +0200 [thread overview]
Message-ID: <20220512154431.GA4536@lxhi-065> (raw)
In-Reply-To: <YnzxvJ7/LGpu92bK@kroah.com>
Dear Greg,
On Do, Mai 12, 2022 at 01:38:36 +0200, Greg Kroah-Hartman wrote:
> On Thu, May 12, 2022 at 01:15:27PM +0200, Eugeniu Rosca wrote:
> > From: Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>
[..]
> > if (!envp[1])
> > - goto exit;
> > + goto exit_path;
>
> No need to rename this, right?
>
> >
> > - envp[2] = NULL;
> > kobject_uevent_env(&hub_dev->kobj, KOBJ_CHANGE, envp);
> >
> > +exit_path:
> > kfree(envp[1]);
> > -exit:
>
> Move this up one line?
Thank you for your comments. Much appreciated.
Please, find the updated version at:
https://lore.kernel.org/linux-usb/1652369834-4480-1-git-send-email-erosca@de.adit-jv.com
Best regards,
Eugeniu
prev parent reply other threads:[~2022-05-12 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 11:15 [PATCH] usb: hub: Simplify error and success path in port_over_current_notify Eugeniu Rosca
2022-05-12 11:38 ` Greg Kroah-Hartman
2022-05-12 15:44 ` Eugeniu Rosca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512154431.GA4536@lxhi-065 \
--to=erosca@de.adit-jv.com \
--cc=Bhuvanesh_Surachari@mentor.com \
--cc=andrew@lunn.ch \
--cc=chris.chiu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mathias.nyman@linux.intel.com \
--cc=naveenkumar.sunkari@in.bosch.com \
--cc=rajatja@google.com \
--cc=rosca.eugeniu@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox