From: "Mychaela N. Falconia" <falcon@freecalypso.org>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
mychaela.falconia@gmail.com
Subject: [PATCH v2 2/6] serial: core: add sysfs attribute to suppress ready signalling on open
Date: Tue, 31 May 2022 04:36:55 +0000 (UTC) [thread overview]
Message-ID: <20220531043655.DDF783740232@freecalypso.org> (raw)
In-Reply-To: <20220531043356.8CAB637401A9@freecalypso.org>
From: Johan Hovold <johan@kernel.org>
Add a nordy sysfs attribute to suppress raising the modem-control lines
on open to signal DTE readiness.
This can be used to prevent undesirable side-effects on open for
applications where the DTR and RTS lines are used for non-standard
purposes such as generating power-on and reset pulses.
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Mychaela N. Falconia <falcon@freecalypso.org>
---
Documentation/ABI/testing/sysfs-tty | 7 +++++++
drivers/tty/serial/serial_core.c | 26 ++++++++++++++++++++++++++
2 files changed, 33 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-tty b/Documentation/ABI/testing/sysfs-tty
index 820e412d38a8..98cb5cf0af75 100644
--- a/Documentation/ABI/testing/sysfs-tty
+++ b/Documentation/ABI/testing/sysfs-tty
@@ -161,3 +161,10 @@ Contact: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Description:
Allows user to detach or attach back the given device as
kernel console. It shows and accepts a boolean variable.
+
+What: /sys/class/tty/ttyS0/nordy
+Date: November 2020
+Contact: Johan Hovold <johan@kernel.org>
+Description:
+ Show and store the port NORDY flag which suppresses raising
+ the modem-control lines on open to signal DTE readiness.
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 9a85b41caa0a..a17ac4efaceb 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2870,6 +2870,30 @@ static ssize_t console_store(struct device *dev,
return ret < 0 ? ret : count;
}
+static ssize_t nordy_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct tty_port *port = dev_get_drvdata(dev);
+
+ return sprintf(buf, "%d\n", tty_port_nordy(port));
+}
+
+static ssize_t nordy_store(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct tty_port *port = dev_get_drvdata(dev);
+ bool val;
+ int ret;
+
+ ret = kstrtobool(buf, &val);
+ if (ret)
+ return ret;
+
+ tty_port_set_nordy(port, val);
+
+ return count;
+}
+
static DEVICE_ATTR_RO(uartclk);
static DEVICE_ATTR_RO(type);
static DEVICE_ATTR_RO(line);
@@ -2884,6 +2908,7 @@ static DEVICE_ATTR_RO(io_type);
static DEVICE_ATTR_RO(iomem_base);
static DEVICE_ATTR_RO(iomem_reg_shift);
static DEVICE_ATTR_RW(console);
+static DEVICE_ATTR_RW(nordy);
static struct attribute *tty_dev_attrs[] = {
&dev_attr_uartclk.attr,
@@ -2900,6 +2925,7 @@ static struct attribute *tty_dev_attrs[] = {
&dev_attr_iomem_base.attr,
&dev_attr_iomem_reg_shift.attr,
&dev_attr_console.attr,
+ &dev_attr_nordy.attr,
NULL
};
--
2.9.0
next prev parent reply other threads:[~2022-05-31 4:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 4:33 [PATCH v2 0/6] serial ports: add ability to suppress raising DTR & RTS on open Mychaela N. Falconia
2022-05-31 4:36 ` [PATCH v2 1/6] tty: add port flag to suppress ready signalling " Mychaela N. Falconia
2022-05-31 4:36 ` Mychaela N. Falconia [this message]
2022-06-02 7:48 ` [PATCH v2 2/6] serial: core: add sysfs attribute " Jiri Slaby
2022-06-02 8:35 ` Mychaela Falconia
2022-06-02 8:50 ` Jiri Slaby
2022-06-02 17:03 ` Mychaela Falconia
2022-05-31 4:37 ` [PATCH v2 3/6] serial: core: fully suppress raising DTR & RTS on open if nordy is set Mychaela N. Falconia
2022-05-31 4:37 ` [PATCH v2 4/6] USB: serial: add sysfs attribute to suppress ready signalling on open Mychaela N. Falconia
2022-05-31 4:37 ` [PATCH v2 5/6] USB: serial: ftdi_sio: pass port to quirk port_probe functions Mychaela N. Falconia
2022-05-31 4:37 ` [PATCH v2 6/6] USB: serial: ftdi_sio: add support for FreeCalypso DUART28C adapter Mychaela N. Falconia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531043655.DDF783740232@freecalypso.org \
--to=falcon@freecalypso.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mychaela.falconia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox