public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: "Mychaela N. Falconia" <falcon@freecalypso.org>
To: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
	mychaela.falconia@gmail.com
Subject: [PATCH v2 3/6] serial: core: fully suppress raising DTR & RTS on open if nordy is set
Date: Tue, 31 May 2022 04:37:01 +0000 (UTC)	[thread overview]
Message-ID: <20220531043701.7AA40374023D@freecalypso.org> (raw)
In-Reply-To: <20220531043356.8CAB637401A9@freecalypso.org>

When nordy sysfs attribute is written as 1, TTY_PORT_NORDY is set,
and the call to raise DTR & RTS in tty_port_raise_dtr_rts() is
suppressed.  However, there is one other place where these signals
are also raised on open: uart_port_startup() in
drivers/tty/serial/serial_core.c - this other point of raising
DTR & RTS also needs to be suppressed if TTY_PORT_NORDY is set.

Signed-off-by: Mychaela N. Falconia <falcon@freecalypso.org>
---
 drivers/tty/serial/serial_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index a17ac4efaceb..2a558813afa1 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -236,7 +236,7 @@ static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
 		 * Setup the RTS and DTR signals once the
 		 * port is open and ready to respond.
 		 */
-		if (init_hw && C_BAUD(tty))
+		if (init_hw && !tty_port_nordy(&state->port) && C_BAUD(tty))
 			uart_port_dtr_rts(uport, 1);
 	}
 
-- 
2.9.0


  parent reply	other threads:[~2022-05-31  4:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31  4:33 [PATCH v2 0/6] serial ports: add ability to suppress raising DTR & RTS on open Mychaela N. Falconia
2022-05-31  4:36 ` [PATCH v2 1/6] tty: add port flag to suppress ready signalling " Mychaela N. Falconia
2022-05-31  4:36 ` [PATCH v2 2/6] serial: core: add sysfs attribute " Mychaela N. Falconia
2022-06-02  7:48   ` Jiri Slaby
2022-06-02  8:35     ` Mychaela Falconia
2022-06-02  8:50       ` Jiri Slaby
2022-06-02 17:03         ` Mychaela Falconia
2022-05-31  4:37 ` Mychaela N. Falconia [this message]
2022-05-31  4:37 ` [PATCH v2 4/6] USB: serial: " Mychaela N. Falconia
2022-05-31  4:37 ` [PATCH v2 5/6] USB: serial: ftdi_sio: pass port to quirk port_probe functions Mychaela N. Falconia
2022-05-31  4:37 ` [PATCH v2 6/6] USB: serial: ftdi_sio: add support for FreeCalypso DUART28C adapter Mychaela N. Falconia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220531043701.7AA40374023D@freecalypso.org \
    --to=falcon@freecalypso.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mychaela.falconia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox