* [PATCH v3] USB: serial: option: Add Telit LE910Cx 0x1250 composition
@ 2022-05-31 10:23 Carlo Lobrano
2022-05-31 17:26 ` Daniele Palmas
2022-06-09 12:27 ` Johan Hovold
0 siblings, 2 replies; 4+ messages in thread
From: Carlo Lobrano @ 2022-05-31 10:23 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman; +Cc: linux-usb, Daniele Palmas, Carlo Lobrano
Add support for the following Telit LE910Cx composition:
0x1250: rmnet, tty, tty, tty, tty
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
---
v3: - fix subject prefix and modem name (s/LN910Cx/LE910Cx)
- more descriptive e-mail content
v2: use RSVD in place of NCTRL for interface 0 (rmnet)
drivers/usb/serial/option.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 152ad882657d..cd9aa61ec801 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1275,6 +1275,8 @@ static const struct usb_device_id option_ids[] = {
.driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff), /* Telit LE910Cx (RNDIS) */
.driver_info = NCTRL(2) | RSVD(3) },
+ { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1250, 0xff), /* Telit LE910Cx (rmnet) */
+ .driver_info = RSVD(0) },
{ USB_DEVICE(TELIT_VENDOR_ID, 0x1260),
.driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
{ USB_DEVICE(TELIT_VENDOR_ID, 0x1261),
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] USB: serial: option: Add Telit LE910Cx 0x1250 composition
2022-05-31 10:23 [PATCH v3] USB: serial: option: Add Telit LE910Cx 0x1250 composition Carlo Lobrano
@ 2022-05-31 17:26 ` Daniele Palmas
2022-06-09 12:27 ` Johan Hovold
1 sibling, 0 replies; 4+ messages in thread
From: Daniele Palmas @ 2022-05-31 17:26 UTC (permalink / raw)
To: Carlo Lobrano; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb
Il giorno mar 31 mag 2022 alle ore 12:23 Carlo Lobrano
<c.lobrano@gmail.com> ha scritto:
>
> Add support for the following Telit LE910Cx composition:
>
> 0x1250: rmnet, tty, tty, tty, tty
>
> Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Reviewed-by: Daniele Palmas <dnlplm@gmail.com>
Thanks,
Daniele
> ---
> v3: - fix subject prefix and modem name (s/LN910Cx/LE910Cx)
> - more descriptive e-mail content
> v2: use RSVD in place of NCTRL for interface 0 (rmnet)
>
> drivers/usb/serial/option.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 152ad882657d..cd9aa61ec801 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1275,6 +1275,8 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
> { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff), /* Telit LE910Cx (RNDIS) */
> .driver_info = NCTRL(2) | RSVD(3) },
> + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1250, 0xff), /* Telit LE910Cx (rmnet) */
> + .driver_info = RSVD(0) },
> { USB_DEVICE(TELIT_VENDOR_ID, 0x1260),
> .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
> { USB_DEVICE(TELIT_VENDOR_ID, 0x1261),
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] USB: serial: option: Add Telit LE910Cx 0x1250 composition
2022-05-31 10:23 [PATCH v3] USB: serial: option: Add Telit LE910Cx 0x1250 composition Carlo Lobrano
2022-05-31 17:26 ` Daniele Palmas
@ 2022-06-09 12:27 ` Johan Hovold
2022-06-10 8:14 ` Carlo Lobrano
1 sibling, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2022-06-09 12:27 UTC (permalink / raw)
To: Carlo Lobrano; +Cc: Greg Kroah-Hartman, linux-usb, Daniele Palmas
On Tue, May 31, 2022 at 12:23:01PM +0200, Carlo Lobrano wrote:
> Add support for the following Telit LE910Cx composition:
>
> 0x1250: rmnet, tty, tty, tty, tty
>
> Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
> ---
> v3: - fix subject prefix and modem name (s/LN910Cx/LE910Cx)
> - more descriptive e-mail content
> v2: use RSVD in place of NCTRL for interface 0 (rmnet)
Thanks for the update (and thanks for reviewing, Daniele).
You forgot to include the lsusb output in v2 and v3 but I found it here:
https://lore.kernel.org/r/20220528073445.50066-1-c.lobrano@gmail.com
> drivers/usb/serial/option.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 152ad882657d..cd9aa61ec801 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1275,6 +1275,8 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
> { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff), /* Telit LE910Cx (RNDIS) */
> .driver_info = NCTRL(2) | RSVD(3) },
> + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1250, 0xff), /* Telit LE910Cx (rmnet) */
> + .driver_info = RSVD(0) },
Looks you can match on the interface SubClass and Protocol using
USB_DEVICE_INFO() and avoid using RSVD() here which is preferred when
possible.
> { USB_DEVICE(TELIT_VENDOR_ID, 0x1260),
> .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
> { USB_DEVICE(TELIT_VENDOR_ID, 0x1261),
Care to respin a v4? You can keep Daniele's reviewed-by tag when
resending (i.e. include it before your SoB).
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] USB: serial: option: Add Telit LE910Cx 0x1250 composition
2022-06-09 12:27 ` Johan Hovold
@ 2022-06-10 8:14 ` Carlo Lobrano
0 siblings, 0 replies; 4+ messages in thread
From: Carlo Lobrano @ 2022-06-10 8:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, Daniele Palmas
Hi Johan,
On Thu, 9 Jun 2022 at 14:27, Johan Hovold <johan@kernel.org> wrote:
>
> On Tue, May 31, 2022 at 12:23:01PM +0200, Carlo Lobrano wrote:
> > Add support for the following Telit LE910Cx composition:
> >
> > 0x1250: rmnet, tty, tty, tty, tty
> >
> > Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
> > ---
> > v3: - fix subject prefix and modem name (s/LN910Cx/LE910Cx)
> > - more descriptive e-mail content
> > v2: use RSVD in place of NCTRL for interface 0 (rmnet)
>
> Thanks for the update (and thanks for reviewing, Daniele).
>
> You forgot to include the lsusb output in v2 and v3 but I found it here:
>
> https://lore.kernel.org/r/20220528073445.50066-1-c.lobrano@gmail.com
>
> > drivers/usb/serial/option.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 152ad882657d..cd9aa61ec801 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -1275,6 +1275,8 @@ static const struct usb_device_id option_ids[] = {
> > .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
> > { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff), /* Telit LE910Cx (RNDIS) */
> > .driver_info = NCTRL(2) | RSVD(3) },
> > + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1250, 0xff), /* Telit LE910Cx (rmnet) */
> > + .driver_info = RSVD(0) },
>
> Looks you can match on the interface SubClass and Protocol using
> USB_DEVICE_INFO() and avoid using RSVD() here which is preferred when
> possible.
This is a good point, I just need to double check if this was true
also with older firmwares I think
>
> > { USB_DEVICE(TELIT_VENDOR_ID, 0x1260),
> > .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
> > { USB_DEVICE(TELIT_VENDOR_ID, 0x1261),
>
> Care to respin a v4? You can keep Daniele's reviewed-by tag when
> resending (i.e. include it before your SoB).
>
> Johan
Carlo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-10 8:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-31 10:23 [PATCH v3] USB: serial: option: Add Telit LE910Cx 0x1250 composition Carlo Lobrano
2022-05-31 17:26 ` Daniele Palmas
2022-06-09 12:27 ` Johan Hovold
2022-06-10 8:14 ` Carlo Lobrano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).