Linux USB
 help / color / mirror / Atom feed
From: Prashant Malani <pmalani@chromium.org>
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: bleung@chromium.org, swboyd@chromium.org,
	heikki.krogerus@linux.intel.com,
	"Prashant Malani" <pmalani@chromium.org>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David Airlie" <airlied@linux.ie>,
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	dri-devel@lists.freedesktop.org (open list:DRM DRIVERS),
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Hsin-Yi Wang" <hsinyi@chromium.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"José Expósito" <jose.exposito89@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Maxime Ripard" <maxime@cerno.tech>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Pin-Yen Lin" <treapking@chromium.org>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Xin Ji" <xji@analogixsemi.com>
Subject: [PATCH v2 1/7] usb: typec: mux: Allow muxes to specify mode-switch
Date: Thu,  9 Jun 2022 18:09:40 +0000	[thread overview]
Message-ID: <20220609181106.3695103-2-pmalani@chromium.org> (raw)
In-Reply-To: <20220609181106.3695103-1-pmalani@chromium.org>

Loosen the typec_mux_match() requirements so that searches where an
alt mode is not specified, but the target mux device lists the
"mode-switch" property, return a success.

This is helpful in Type C port drivers which would like to get a pointer
to the mux switch associated with a Type C port, but don't want to
specify a particular alt mode.

Signed-off-by: Prashant Malani <pmalani@chromium.org>
---

Changes since v1:
- No changes.

 drivers/usb/typec/mux.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
index fd55c2c516a5..464330776cd6 100644
--- a/drivers/usb/typec/mux.c
+++ b/drivers/usb/typec/mux.c
@@ -281,9 +281,13 @@ static void *typec_mux_match(struct fwnode_handle *fwnode, const char *id,
 	if (match)
 		goto find_mux;
 
-	/* Accessory Mode muxes */
 	if (!desc) {
-		match = fwnode_property_present(fwnode, "accessory");
+		/*
+		 * Accessory Mode muxes & muxes which explicitly specify
+		 * the required identifier can avoid SVID matching.
+		 */
+		match = fwnode_property_present(fwnode, "accessory") ||
+			fwnode_property_present(fwnode, id);
 		if (match)
 			goto find_mux;
 		return NULL;
-- 
2.36.1.476.g0c4daa206d-goog


  reply	other threads:[~2022-06-09 18:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 18:09 [PATCH v2 0/7] usb: typec: Introduce typec-switch binding Prashant Malani
2022-06-09 18:09 ` Prashant Malani [this message]
2022-06-14  7:42   ` [PATCH v2 1/7] usb: typec: mux: Allow muxes to specify mode-switch Heikki Krogerus
2022-06-14  8:27   ` AngeloGioacchino Del Regno
2022-06-09 18:09 ` [PATCH v2 2/7] usb: typec: mux: Add CONFIG guards for functions Prashant Malani
2022-06-14  8:10   ` Heikki Krogerus
2022-06-14  8:27   ` AngeloGioacchino Del Regno
2022-06-09 18:09 ` [PATCH v2 3/7] dt-bindings: usb: Add Type-C switch binding Prashant Malani
2022-06-13 20:38   ` Nícolas F. R. A. Prado
2022-06-13 20:44     ` Prashant Malani
2022-06-09 18:09 ` [PATCH v2 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Prashant Malani
2022-06-09 18:09 ` [PATCH v2 5/7] drm/bridge: anx7625: Register number of Type C switches Prashant Malani
2022-06-13 20:45   ` Nícolas F. R. A. Prado
2022-06-13 20:48     ` Prashant Malani
2022-06-14  8:22   ` AngeloGioacchino Del Regno
2022-06-14 18:13     ` Prashant Malani
2022-06-09 18:09 ` [PATCH v2 6/7] drm/bridge: anx7625: Register Type-C mode switches Prashant Malani
2022-06-14  8:18   ` AngeloGioacchino Del Regno
2022-06-14 16:57     ` Prashant Malani
2022-06-15  8:45       ` AngeloGioacchino Del Regno
2022-06-15 17:00         ` Prashant Malani
2022-06-09 18:09 ` [PATCH v2 7/7] drm/bridge: anx7625: Add typec_mux_set callback function Prashant Malani
2022-06-13 20:51   ` Nícolas F. R. A. Prado
2022-06-13 21:31     ` Prashant Malani
2022-06-14  8:15   ` AngeloGioacchino Del Regno
2022-06-14  9:08     ` Pin-yen Lin
2022-06-14 16:58       ` Prashant Malani
2022-06-15 13:57         ` AngeloGioacchino Del Regno
2022-06-13 20:58 ` [PATCH v2 0/7] usb: typec: Introduce typec-switch binding Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609181106.3695103-2-pmalani@chromium.org \
    --to=pmalani@chromium.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=andrzej.hajda@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bleung@chromium.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hsinyi@chromium.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=jose.exposito89@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=narmstrong@baylibre.com \
    --cc=nfraprado@collabora.com \
    --cc=robert.foss@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=swboyd@chromium.org \
    --cc=treapking@chromium.org \
    --cc=tzimmermann@suse.de \
    --cc=xji@analogixsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox