From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE58C433EF for ; Mon, 13 Jun 2022 21:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352198AbiFMVRI (ORCPT ); Mon, 13 Jun 2022 17:17:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352217AbiFMVQ4 (ORCPT ); Mon, 13 Jun 2022 17:16:56 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79134D10D; Mon, 13 Jun 2022 13:58:49 -0700 (PDT) Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1E55D6601671; Mon, 13 Jun 2022 21:58:45 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1655153927; bh=TmikzqWBrB46qOMNrEdA0IqJB77LnzkhuMwjJ/1ZJBw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iKZzCOUbY+UJhBB9Z3ZyUUmdIykmqpdNuQBWJpxbwBC0Wp+rz0VBIMnI6o7bt9BFW MgxULPUIwA82jhxgDNAUxqr8shbAVRhSkT2inQeb3BUQVZRJsZWWktIEw/NqBh24gF eMHrYrHdQ7WBJa4kltnWaNYpYTPRRoG3o9MbN8dnMsEXHM9bVoD6gO2sSVzlIKtoGC WmqmMXdSvwN+OiDvRYLb+xn266m0rnLiF/lfsoHXCalt2QsA4hiUOAW6Aa8Yp5P1D7 t2zcgUao/fkmxW8wsrAwbyxmaNoVena1oizM/3KP4Gy2U0SGHkHr+kKpwBQwmu3y0a ThbGcSpSGXbww== Date: Mon, 13 Jun 2022 16:58:40 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Prashant Malani Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, bleung@chromium.org, swboyd@chromium.org, heikki.krogerus@linux.intel.com, Andrzej Hajda , AngeloGioacchino Del Regno , Daniel Vetter , David Airlie , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:DRM DRIVERS" , Greg Kroah-Hartman , Hsin-Yi Wang , Jernej Skrabec , Jonas Karlman , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Krzysztof Kozlowski , Laurent Pinchart , Maxime Ripard , Neil Armstrong , Pin-Yen Lin , Robert Foss , Rob Herring , Sam Ravnborg , Thomas Zimmermann , Tzung-Bi Shih , Xin Ji Subject: Re: [PATCH v2 0/7] usb: typec: Introduce typec-switch binding Message-ID: <20220613205840.x7bgrj567prroede@notapiano> References: <20220609181106.3695103-1-pmalani@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220609181106.3695103-1-pmalani@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Jun 09, 2022 at 06:09:39PM +0000, Prashant Malani wrote: > This series introduces a binding for Type-C data lane switches. These > control the routing and operating modes of USB Type-C data lanes based > on the PD messaging from the Type-C port driver regarding connected > peripherals. > > The first patch introduces a change to the Type-C mux class mode-switch > matching code, while the second adds a config guard to a Type-C header. > The next couple of patches introduce the new "typec-switch" binding as > well as one user of it (the ANX7625 drm bridge). > > The remaining patches add functionality to the anx7625 driver to > register the mode-switches, as well as program its crosspoint > switch depending on which Type-C port has a DisplayPort (DP) peripheral > connected to it. > > v1: https://lore.kernel.org/linux-usb/20220607190131.1647511-1-pmalani@chromium.org/ > > Changes since v1: > - Fixed function signature error in "else case" of typec_mux.h > - typec-switch.yaml: Fixed indentation, compatible, and node names in examples. > - anx7625.yaml: > + Introduced patternProperties for "switch" children (suggested by Krzysztof Kozlowski). > + Added unevaluatedProperties descriptor (suggested by Krzysztof Kozlowski). > + Added "address-cells" and "size-cells" properties to "switches". > > Pin-Yen Lin (1): > drm/bridge: anx7625: Add typec_mux_set callback function > > Prashant Malani (6): > usb: typec: mux: Allow muxes to specify mode-switch > usb: typec: mux: Add CONFIG guards for functions > dt-bindings: usb: Add Type-C switch binding > dt-bindings: drm/bridge: anx7625: Add mode-switch support > drm/bridge: anx7625: Register number of Type C switches > drm/bridge: anx7625: Register Type-C mode switches For the whole series, Reviewed-by: Nícolas F. R. A. Prado Tested-by: Nícolas F. R. A. Prado Tested that external display works on both ports of mt8192-asurada-spherion. Thanks, Nícolas > > .../display/bridge/analogix,anx7625.yaml | 63 ++++++++ > .../devicetree/bindings/usb/typec-switch.yaml | 74 +++++++++ > drivers/gpu/drm/bridge/analogix/anx7625.c | 151 ++++++++++++++++++ > drivers/gpu/drm/bridge/analogix/anx7625.h | 20 +++ > drivers/usb/typec/mux.c | 8 +- > include/linux/usb/typec_mux.h | 38 +++++ > 6 files changed, 352 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/typec-switch.yaml > > -- > 2.36.1.476.g0c4daa206d-goog >