From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Chunfeng Yun" <chunfeng.yun@mediatek.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-usb@vger.kernel.org
Subject: [PATCH 2/3] dt-bindings: usb: mtk-xhci: Allow middle optional clocks to be missing
Date: Fri, 17 Jun 2022 18:29:15 -0400 [thread overview]
Message-ID: <20220617222916.2435618-3-nfraprado@collabora.com> (raw)
In-Reply-To: <20220617222916.2435618-1-nfraprado@collabora.com>
The current clock list in the binding doesn't allow for one of the
optional clocks to be missing and a subsequent clock to be present. An
example where this is an issue is in mt8192.dtsi, which has "sys_ck",
"ref_ck", "xhci_ck" and would cause dtbs_check warnings.
Change the clock list in a way that allows the middle optional clocks to
be missing, while still guaranteeing a fixed order. The "ref_ck" is kept
as a const even though it is optional for simplicity, since it is
present in all current dts files.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
.../devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
index 63cbc2b62d18..99a1b233ec90 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
@@ -80,8 +80,13 @@ properties:
items:
- const: sys_ck # required, the following ones are optional
- const: ref_ck
- - const: mcu_ck
- - const: dma_ck
+ - enum:
+ - mcu_ck
+ - dma_ck
+ - xhci_ck
+ - enum:
+ - dma_ck
+ - xhci_ck
- const: xhci_ck
assigned-clocks:
--
2.36.1
next prev parent reply other threads:[~2022-06-17 22:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 22:29 [PATCH 0/3] Fixes for dtbs_check warnings on Mediatek XHCI nodes Nícolas F. R. A. Prado
2022-06-17 22:29 ` [PATCH 1/3] dt-bindings: usb: mtk-xhci: Allow wakeup interrupt-names to be optional Nícolas F. R. A. Prado
2022-06-18 1:30 ` Krzysztof Kozlowski
2022-06-19 7:47 ` Chunfeng Yun
2022-06-17 22:29 ` Nícolas F. R. A. Prado [this message]
2022-06-18 1:25 ` [PATCH 2/3] dt-bindings: usb: mtk-xhci: Allow middle optional clocks to be missing Krzysztof Kozlowski
2022-06-19 7:46 ` Chunfeng Yun
2022-06-19 12:05 ` Krzysztof Kozlowski
2022-06-20 6:59 ` Chunfeng Yun
2022-06-20 8:50 ` Krzysztof Kozlowski
2022-06-20 15:50 ` Nícolas F. R. A. Prado
2022-06-21 7:14 ` Krzysztof Kozlowski
2022-06-22 1:57 ` Chunfeng Yun
2022-06-22 6:10 ` Wenbin Mei
2022-06-22 13:22 ` Nícolas F. R. A. Prado
2022-06-19 7:40 ` Chunfeng Yun
2022-06-19 11:49 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617222916.2435618-3-nfraprado@collabora.com \
--to=nfraprado@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox