Linux USB
 help / color / mirror / Atom feed
From: Xin Ji <xji@analogixsemi.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] usb: typec: anx7411: use semi-colons instead of commas
Date: Fri, 22 Jul 2022 15:17:29 +0800	[thread overview]
Message-ID: <20220722071729.GC2853704@anxtwsw-Precision-3640-Tower> (raw)
In-Reply-To: <YtpD4MKBa43higNc@kili>

On Fri, Jul 22, 2022 at 09:29:52AM +0300, Dan Carpenter wrote:
> Semi colons and commas are equivalent in this context but semi-colons
> are better style.
Hi Dan Carpenter, thanks for your patch.

Reviewed-by: Xin Ji <xji@analogixsemi.com>

Thanks,
Xin
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/usb/typec/anx7411.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
> index 311b56aaea9f..18a6a6a8b9eb 100644
> --- a/drivers/usb/typec/anx7411.c
> +++ b/drivers/usb/typec/anx7411.c
> @@ -1421,12 +1421,12 @@ static int anx7411_psy_register(struct anx7411_data *ctx)
>  	psy_desc->type = POWER_SUPPLY_TYPE_USB;
>  	psy_desc->usb_types = anx7411_psy_usb_types;
>  	psy_desc->num_usb_types = ARRAY_SIZE(anx7411_psy_usb_types);
> -	psy_desc->properties = anx7411_psy_props,
> -	psy_desc->num_properties = ARRAY_SIZE(anx7411_psy_props),
> +	psy_desc->properties = anx7411_psy_props;
> +	psy_desc->num_properties = ARRAY_SIZE(anx7411_psy_props);
>  
> -	psy_desc->get_property = anx7411_psy_get_prop,
> -	psy_desc->set_property = anx7411_psy_set_prop,
> -	psy_desc->property_is_writeable = anx7411_psy_prop_writeable,
> +	psy_desc->get_property = anx7411_psy_get_prop;
> +	psy_desc->set_property = anx7411_psy_set_prop;
> +	psy_desc->property_is_writeable = anx7411_psy_prop_writeable;
>  
>  	ctx->usb_type = POWER_SUPPLY_USB_TYPE_C;
>  	ctx->psy = devm_power_supply_register(ctx->dev, psy_desc, &psy_cfg);
> -- 
> 2.35.1

  reply	other threads:[~2022-07-22  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22  6:25 [PATCH 1/3] usb: typec: anx7411: Fix an array out of bounds Dan Carpenter
2022-07-22  6:29 ` [PATCH 2/3] usb: typec: anx7411: fix error checking in anx7411_get_gpio_irq() Dan Carpenter
2022-07-22  7:16   ` Xin Ji
2022-07-22  6:29 ` [PATCH 3/3] usb: typec: anx7411: use semi-colons instead of commas Dan Carpenter
2022-07-22  7:17   ` Xin Ji [this message]
2022-07-22  7:15 ` [PATCH 1/3] usb: typec: anx7411: Fix an array out of bounds Xin Ji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220722071729.GC2853704@anxtwsw-Precision-3640-Tower \
    --to=xji@analogixsemi.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox